From: Jakub Kicinski <kuba@kernel.org>
To: Anand Kumar Shaw <anandkrshawheritage@gmail.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@kernel.org,
daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
davem@davemloft.net, sdf@fomichev.me, andrii@kernel.org,
martin.lau@linux.dev
Subject: Re: [PATCH] bpf: cpumap: add missing XDP_ABORTED handling in xdp prog runner
Date: Tue, 17 Feb 2026 14:37:51 -0800 [thread overview]
Message-ID: <20260217143751.2e7bdefc@kernel.org> (raw)
In-Reply-To: <20260216150601.9454-1-anandkrshawheritage@gmail.com>
On Mon, 16 Feb 2026 20:36:01 +0530 Anand Kumar Shaw wrote:
> default:
> bpf_warn_invalid_xdp_action(NULL, rcpu->prog, act);
> fallthrough;
> + case XDP_ABORTED:
> + trace_xdp_exception(xdpf->dev_rx, rcpu->prog, act);
> + fallthrough;
Why are you populating netdev with xdpf->dev_rx when the
bpf_warn_invalid_xdp_action() above did not? Either both or neither should?
next prev parent reply other threads:[~2026-02-17 22:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 15:06 [PATCH] bpf: cpumap: add missing XDP_ABORTED handling in xdp prog runner Anand Kumar Shaw
2026-02-17 22:37 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-02-18 4:16 Anand Kumar Shaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260217143751.2e7bdefc@kernel.org \
--to=kuba@kernel.org \
--cc=anandkrshawheritage@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox