public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Joshua Washington <joshwash@google.com>
Cc: netdev@vger.kernel.org,
	Harshitha Ramamurthy <hramamurthy@google.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Willem de Bruijn <willemb@google.com>,
	Praveen Kaligineedi <pkaligineedi@google.com>,
	Rushil Gupta <rushilg@google.com>,
	Bailey Forrest <bcf@google.com>,
	linux-kernel@vger.kernel.org, Ankit Garg <nktgrg@google.com>,
	stable@vger.kernel.org, Jordan Rhee <jordanrhee@google.com>
Subject: Re: [PATCH net] gve: fix incorrect buffer cleanup in gve_tx_clean_pending_packets for QPL
Date: Tue, 17 Feb 2026 17:26:09 -0800	[thread overview]
Message-ID: <20260217172609.4c6ee746@kernel.org> (raw)
In-Reply-To: <20260214001226.744193-1-joshwash@google.com>

On Fri, 13 Feb 2026 16:12:26 -0800 Joshua Washington wrote:
>  }
>  
> +static void gve_unmap_packet(struct device *dev,
> +			     struct gve_tx_pending_packet_dqo *pkt);
> +
>  /* gve_tx_free_desc - Cleans up all pending tx requests and buffers.

Per kernel coding style forward declarations should be avoided.
Please move the functions instead.
-- 
pw-bot: cr

      reply	other threads:[~2026-02-18  1:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-14  0:12 [PATCH net] gve: fix incorrect buffer cleanup in gve_tx_clean_pending_packets for QPL Joshua Washington
2026-02-18  1:26 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260217172609.4c6ee746@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=bcf@google.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hramamurthy@google.com \
    --cc=jordanrhee@google.com \
    --cc=joshwash@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nktgrg@google.com \
    --cc=pabeni@redhat.com \
    --cc=pkaligineedi@google.com \
    --cc=rushilg@google.com \
    --cc=stable@vger.kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox