From: Greg KH <gregkh@linuxfoundation.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
stable@vger.kernel.org, netdev@vger.kernel.org, kuba@kernel.org,
Daniel Dao <dqminh@cloudflare.com>,
Ignat Korchagin <ignat@cloudflare.com>,
Jakub Sitnicki <jakub@cloudflare.com>
Subject: Re: [PATCH stable v5.15,v6.1] Revert "wireguard: device: enable threaded NAPI"
Date: Tue, 17 Feb 2026 12:25:20 +0100 [thread overview]
Message-ID: <2026021751-vocalist-enroll-6b2a@gregkh> (raw)
In-Reply-To: <cf804cbc-a8d3-4b11-9a46-679f4d10fd38@iogearbox.net>
On Tue, Feb 17, 2026 at 12:01:15PM +0100, Daniel Borkmann wrote:
> On 2/17/26 11:33 AM, Greg KH wrote:
> > On Mon, Feb 16, 2026 at 10:33:53PM +0100, Jason A. Donenfeld wrote:
> > > On Mon, Feb 16, 2026 at 10:31 PM Daniel Borkmann <daniel@iogearbox.net> wrote:
> > > > Technically, the backport of commit db9ae3b6b43c ("wireguard: device:
> > > > enable threaded NAPI") to stable should not have happened since it is
> > > > more of an optimization rather than a pure fix and addresses a NAPI
> > > > situation with utilizing many WireGuard tunnel devices in parallel.
> > >
> > > Indeed.
> > >
> > > > Revert it from stable given the backport triggers a regression for
> > > > mentioned kernels.
> > >
> > > Thanks.
> > >
> > > Acked-by: Jason A. Donenfeld <Jason@zx2c4.com>
> > >
> > > If that helps with Greg queueing this up.
> >
> > I'll go queue it up now, thanks for the revert. But it's ok being in
> > the 6.6.y and 6.12.y and newer kernels, right?
> Great question; from a stable kernel PoV that commit to enable threaded
> NAPI for wireguard by default went in natively (aka not via backports) in
> linux-6.18.y branch.
>
> Given there have been backports around threaded NAPI and then reverts again
> e.g. [0-2] I think it would be best to also queue this revert here for 6.6.y
> and 6.12.y stable kernels. The same applies that it's more of an optimization
> rather than a pure fix.
>
> I've added CF folks to Cc given they have been testing v6.6 with [2] but
> then it later got reverted again in [1] upon request. Feel free to holler
> if you think otherwise.
>
> Thanks,
> Daniel
>
> [0] https://lore.kernel.org/netdev/CA+wXwBTT74RErDGAnj98PqS=wvdh8eM1pi4q6tTdExtjnokKqA@mail.gmail.com/
> [1] https://lore.kernel.org/stable/20260204143848.216983148@linuxfoundation.org/
> [2] https://lore.kernel.org/all/20260120103833.4kssDD1Y@linutronix.de/
>
Ok, to be "safe", I'll queue this revert up for those other kernel
branches as well, thanks! Worst case, we get someone who asks for it to
come back :)
thanks,
greg k-h
prev parent reply other threads:[~2026-02-17 11:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 21:31 [PATCH stable v5.15,v6.1] Revert "wireguard: device: enable threaded NAPI" Daniel Borkmann
2026-02-16 21:33 ` Jason A. Donenfeld
2026-02-17 10:33 ` Greg KH
2026-02-17 11:01 ` Daniel Borkmann
2026-02-17 11:25 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026021751-vocalist-enroll-6b2a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Jason@zx2c4.com \
--cc=daniel@iogearbox.net \
--cc=dqminh@cloudflare.com \
--cc=ignat@cloudflare.com \
--cc=jakub@cloudflare.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox