From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: Yael Chemla <ychemla@nvidia.com>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
Willem de Bruijn <willemb@google.com>,
shuah@kernel.org, linux-kselftest@vger.kernel.org,
Tariq Toukan <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
noren@nvidia.com
Subject: Re: [PATCH net-next v2 1/2] selftests: drv-net: rss: validate min RSS table size
Date: Wed, 18 Feb 2026 07:45:01 -0800 [thread overview]
Message-ID: <20260218074501.7245718b@kernel.org> (raw)
In-Reply-To: <d56f8f9a-7377-4892-8b29-d5be53eed08e@gmail.com>
On Wed, 18 Feb 2026 10:02:01 +0200 Tariq Toukan wrote:
> > The minimum
> > SHOULD be at least 4 times the number of supported receive queues.
> >
> > so I guess the 4x isn't exactly a new recommendation.
>
> My position is as follows:
> Provide the appropriate factor *if possible* (currently it is 2x, and we
> will likely increase it to 4x).
> However, do not limit the maximum nch if the factor cannot be satisfied
> - even if that results in the selftest failing.
Yes, that's definitely fair. We can adjust the comment in the test
to make that clear. The user may want to use the queues in a different
RSS context / zero-copy so limiting queue count would be the wrong
direction. The test, is only signaling practicality of using all queues
in the main context.
prev parent reply other threads:[~2026-02-18 15:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 22:54 [PATCH net-next v2 1/2] selftests: drv-net: rss: validate min RSS table size Jakub Kicinski
2026-01-31 22:54 ` [PATCH net-next v2 2/2] docs: networking: mention that RSS table should be 4x the queue count Jakub Kicinski
2026-02-01 7:56 ` Eric Dumazet
2026-02-03 1:10 ` [PATCH net-next v2 1/2] selftests: drv-net: rss: validate min RSS table size patchwork-bot+netdevbpf
2026-02-11 20:10 ` Yael Chemla
2026-02-11 21:43 ` Jakub Kicinski
2026-02-12 9:41 ` Tariq Toukan
2026-02-13 1:22 ` Jakub Kicinski
2026-02-16 8:28 ` Tariq Toukan
2026-02-17 21:57 ` Jakub Kicinski
2026-02-18 8:02 ` Tariq Toukan
2026-02-18 15:45 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260218074501.7245718b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
--cc=willemb@google.com \
--cc=ychemla@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox