public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: microchip: lan743x: add ethtool nway_reset support
@ 2026-02-18 19:56 Nicolai Buchwitz
  2026-02-18 20:40 ` Andrew Lunn
  2026-02-19 14:57 ` Russell King (Oracle)
  0 siblings, 2 replies; 3+ messages in thread
From: Nicolai Buchwitz @ 2026-02-18 19:56 UTC (permalink / raw)
  To: netdev
  Cc: Nicolai Buchwitz, Bryan Whitehead, UNGLinuxDriver, Andrew Lunn,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Russell King, linux-kernel

Wire phylink_ethtool_nway_reset() as the .nway_reset ethtool operation,
allowing userspace to restart PHY autonegotiation via 'ethtool -r'.

Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
---
 drivers/net/ethernet/microchip/lan743x_ethtool.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/ethernet/microchip/lan743x_ethtool.c b/drivers/net/ethernet/microchip/lan743x_ethtool.c
index 8a3c1ecc7866..9195419ecee0 100644
--- a/drivers/net/ethernet/microchip/lan743x_ethtool.c
+++ b/drivers/net/ethernet/microchip/lan743x_ethtool.c
@@ -1079,6 +1079,13 @@ static int lan743x_ethtool_set_eee(struct net_device *netdev,
 	return phylink_ethtool_set_eee(adapter->phylink, eee);
 }
 
+static int lan743x_ethtool_nway_reset(struct net_device *netdev)
+{
+	struct lan743x_adapter *adapter = netdev_priv(netdev);
+
+	return phylink_ethtool_nway_reset(adapter->phylink);
+}
+
 static int
 lan743x_ethtool_set_link_ksettings(struct net_device *netdev,
 				   const struct ethtool_link_ksettings *cmd)
@@ -1369,6 +1376,7 @@ const struct ethtool_ops lan743x_ethtool_ops = {
 	.set_rxfh = lan743x_ethtool_set_rxfh,
 	.get_rxfh_fields = lan743x_ethtool_get_rxfh_fields,
 	.get_ts_info = lan743x_ethtool_get_ts_info,
+	.nway_reset = lan743x_ethtool_nway_reset,
 	.get_eee = lan743x_ethtool_get_eee,
 	.set_eee = lan743x_ethtool_set_eee,
 	.get_link_ksettings = lan743x_ethtool_get_link_ksettings,
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: microchip: lan743x: add ethtool nway_reset support
  2026-02-18 19:56 [PATCH] net: microchip: lan743x: add ethtool nway_reset support Nicolai Buchwitz
@ 2026-02-18 20:40 ` Andrew Lunn
  2026-02-19 14:57 ` Russell King (Oracle)
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2026-02-18 20:40 UTC (permalink / raw)
  To: Nicolai Buchwitz
  Cc: netdev, Bryan Whitehead, UNGLinuxDriver, Andrew Lunn,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Russell King, linux-kernel

On Wed, Feb 18, 2026 at 08:56:15PM +0100, Nicolai Buchwitz wrote:
> Wire phylink_ethtool_nway_reset() as the .nway_reset ethtool operation,
> allowing userspace to restart PHY autonegotiation via 'ethtool -r'.
> 
> Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>

We are in the merge window at the moment, so patches are not being
accepted.

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

Also, please indicate in the subject line which tree this is for.

The change itself looks O.K.

    Andrew

---
pw-bot: cr

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: microchip: lan743x: add ethtool nway_reset support
  2026-02-18 19:56 [PATCH] net: microchip: lan743x: add ethtool nway_reset support Nicolai Buchwitz
  2026-02-18 20:40 ` Andrew Lunn
@ 2026-02-19 14:57 ` Russell King (Oracle)
  1 sibling, 0 replies; 3+ messages in thread
From: Russell King (Oracle) @ 2026-02-19 14:57 UTC (permalink / raw)
  To: Nicolai Buchwitz
  Cc: netdev, Bryan Whitehead, UNGLinuxDriver, Andrew Lunn,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	linux-kernel

On Wed, Feb 18, 2026 at 08:56:15PM +0100, Nicolai Buchwitz wrote:
> Wire phylink_ethtool_nway_reset() as the .nway_reset ethtool operation,
> allowing userspace to restart PHY autonegotiation via 'ethtool -r'.
> 
> Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>

When you resubmit for net-next (please read the URL Andrew gave you)
please include:

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-19 14:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-18 19:56 [PATCH] net: microchip: lan743x: add ethtool nway_reset support Nicolai Buchwitz
2026-02-18 20:40 ` Andrew Lunn
2026-02-19 14:57 ` Russell King (Oracle)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox