From: Yury Norov <ynorov@nvidia.com>
To: linux-kernel@vger.kernel.org,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Andrew Morton <akpm@linux-foundation.org>,
Antoine Tenart <atenart@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Eric Dumazet <edumazet@google.com>,
Geetha sowjanya <gakula@marvell.com>,
Ingo Molnar <mingo@kernel.org>, Jakub Kicinski <kuba@kernel.org>,
James Clark <james.clark@linaro.org>,
Jerin Jacob <jerinj@marvell.com>,
Linu Cherian <lcherian@marvell.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Mike Leach <mike.leach@linaro.org>,
Moritz Fischer <mdf@kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Simon Horman <horms@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Subbaraya Sundeep <sbhatta@marvell.com>,
Sunil Goutham <sgoutham@marvell.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Tom Rix <trix@redhat.com>, Xu Yilun <yilun.xu@intel.com>,
Yajun Deng <yajun.deng@linux.dev>,
Yury Norov <yury.norov@gmail.com>,
Zhang Rui <rui.zhang@intel.com>, hariprasad <hkelam@marvell.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-fpga@vger.kernel.org, linux-pm@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org
Cc: Yury Norov <ynorov@nvidia.com>
Subject: [PATCH 08/12] coresight: don't use bitmap_print_to_pagebuf()
Date: Thu, 19 Feb 2026 13:14:00 -0500 [thread overview]
Message-ID: <20260219181407.290201-9-ynorov@nvidia.com> (raw)
In-Reply-To: <20260219181407.290201-1-ynorov@nvidia.com>
Switch to a more common scnprintf("%*pbl") where appropriate.
Signed-off-by: Yury Norov <ynorov@nvidia.com>
---
.../hwtracing/coresight/coresight-cti-sysfs.c | 33 +++++++++----------
1 file changed, 15 insertions(+), 18 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-cti-sysfs.c b/drivers/hwtracing/coresight/coresight-cti-sysfs.c
index 572b80ee96fb..182c8db52a04 100644
--- a/drivers/hwtracing/coresight/coresight-cti-sysfs.c
+++ b/drivers/hwtracing/coresight/coresight-cti-sysfs.c
@@ -606,14 +606,11 @@ static ssize_t chan_gate_enable_show(struct device *dev,
struct cti_drvdata *drvdata = dev_get_drvdata(dev->parent);
struct cti_config *cfg = &drvdata->config;
unsigned long ctigate_bitmask = cfg->ctigate;
- int size = 0;
if (cfg->ctigate == 0)
- size = sprintf(buf, "\n");
- else
- size = bitmap_print_to_pagebuf(true, buf, &ctigate_bitmask,
- cfg->nr_ctm_channels);
- return size;
+ return sprintf(buf, "\n");
+
+ return scnprintf(buf, rest_of_page(buf), "%*pbl\n", cfg->nr_ctm_channels, &ctigate_bitmask);
}
static DEVICE_ATTR_RW(chan_gate_enable);
@@ -710,12 +707,13 @@ static ssize_t trigout_filtered_show(struct device *dev,
{
struct cti_drvdata *drvdata = dev_get_drvdata(dev->parent);
struct cti_config *cfg = &drvdata->config;
- int size = 0, nr_trig_max = cfg->nr_trig_max;
+ int nr_trig_max = cfg->nr_trig_max;
unsigned long mask = cfg->trig_out_filter;
- if (mask)
- size = bitmap_print_to_pagebuf(true, buf, &mask, nr_trig_max);
- return size;
+ if (mask == 0)
+ return 0;
+
+ return scnprintf(buf, rest_of_page(buf), "%*pbl\n", nr_trig_max, &mask);
}
static DEVICE_ATTR_RO(trigout_filtered);
@@ -834,7 +832,7 @@ static ssize_t print_chan_list(struct device *dev,
{
struct cti_drvdata *drvdata = dev_get_drvdata(dev->parent);
struct cti_config *config = &drvdata->config;
- int size, i;
+ int i;
unsigned long inuse_bits = 0, chan_mask;
/* scan regs to get bitmap of channels in use. */
@@ -852,11 +850,10 @@ static ssize_t print_chan_list(struct device *dev,
/* list of channels, or 'none' */
chan_mask = GENMASK(config->nr_ctm_channels - 1, 0);
if (inuse_bits & chan_mask)
- size = bitmap_print_to_pagebuf(true, buf, &inuse_bits,
- config->nr_ctm_channels);
- else
- size = sprintf(buf, "\n");
- return size;
+ return scnprintf(buf, rest_of_page(buf), "%*pbl\n",
+ config->nr_ctm_channels, &inuse_bits);
+
+ return sprintf(buf, "\n");
}
static ssize_t chan_inuse_show(struct device *dev,
@@ -928,7 +925,7 @@ static ssize_t trigin_sig_show(struct device *dev,
struct cti_config *cfg = &drvdata->config;
unsigned long mask = con->con_in->used_mask;
- return bitmap_print_to_pagebuf(true, buf, &mask, cfg->nr_trig_max);
+ return scnprintf(buf, rest_of_page(buf), "%*pbl\n", cfg->nr_trig_max, &mask);
}
static ssize_t trigout_sig_show(struct device *dev,
@@ -942,7 +939,7 @@ static ssize_t trigout_sig_show(struct device *dev,
struct cti_config *cfg = &drvdata->config;
unsigned long mask = con->con_out->used_mask;
- return bitmap_print_to_pagebuf(true, buf, &mask, cfg->nr_trig_max);
+ return scnprintf(buf, rest_of_page(buf), "%*pbl\n", cfg->nr_trig_max, &mask);
}
/* convert a sig type id to a name */
--
2.43.0
next prev parent reply other threads:[~2026-02-19 18:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 18:13 [PATCH 00/12] cleanup bitmaps printing in sysfs Yury Norov
2026-02-19 18:13 ` [PATCH 01/12] powerpc/xive: simplify xive_spapr_debug_show() Yury Norov
2026-02-23 13:13 ` Shrikanth Hegde
2026-02-19 18:13 ` [PATCH 02/12] octeontx2-af: siplify rvu_debugfs Yury Norov
2026-02-19 18:13 ` [PATCH 03/12] thermal: intel: switch cpumask_get() to using cpumask_print_to_pagebuf() Yury Norov
2026-02-19 18:13 ` [PATCH 04/12] lib/prime_numbers: drop temporary buffer in dump_primes() Yury Norov
2026-02-19 18:13 ` [PATCH 05/12] bitmap: switch test to scnprintf("%*pbl") Yury Norov
2026-02-19 18:13 ` [PATCH 06/12] bitmap: align test_bitmap output Yury Norov
2026-02-19 18:13 ` [PATCH 07/12] mm: add rest_of_page() macro Yury Norov
2026-02-19 18:14 ` Yury Norov [this message]
2026-02-19 18:42 ` [PATCH 08/12] coresight: don't use bitmap_print_to_pagebuf() Thomas Weißschuh
2026-02-19 18:14 ` [PATCH 09/12] fpga: m10bmc-sec: switch show_canceled_csk() to using scnprintf() Yury Norov
2026-02-19 23:43 ` Russ Weight
2026-02-26 7:39 ` Xu Yilun
2026-02-19 18:14 ` [PATCH 10/12] net-sysfs: switch xps_queue_show() " Yury Norov
2026-02-19 18:14 ` [PATCH 11/12] cpumask: switch cpumap_print_to_pagebuf() " Yury Norov
2026-02-19 18:14 ` [PATCH 12/12] bitmap: drop bitmap_print_to_pagebuf() Yury Norov
2026-02-19 19:41 ` [PATCH 00/12] cleanup bitmaps printing in sysfs Jakub Kicinski
2026-03-03 18:17 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260219181407.290201-9-ynorov@nvidia.com \
--to=ynorov@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=atenart@kernel.org \
--cc=brauner@kernel.org \
--cc=chleroy@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=james.clark@linaro.org \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukasz.luba@arm.com \
--cc=maddy@linux.ibm.com \
--cc=mdf@kernel.org \
--cc=mike.leach@linaro.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sbhatta@marvell.com \
--cc=sdf@fomichev.me \
--cc=sgoutham@marvell.com \
--cc=suzuki.poulose@arm.com \
--cc=trix@redhat.com \
--cc=yajun.deng@linux.dev \
--cc=yilun.xu@intel.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox