From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: <andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<danishanwar@ti.com>, <rogerq@kernel.org>, <horms@kernel.org>,
<mwalle@kernel.org>, <nm@ti.com>, <v-singh1@ti.com>,
<vadim.fedorenko@linux.dev>, <matthias.schiffer@ew.tq-group.com>,
<vigneshr@ti.com>, <m-malladi@ti.com>, <jacob.e.keller@intel.com>
Cc: <stable@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <srk@ti.com>,
<s-vadapalli@ti.com>
Subject: [PATCH net 0/3] Fix Unbalanced IRQ Enable for CPSW and ICSSG
Date: Fri, 20 Feb 2026 09:41:56 +0530 [thread overview]
Message-ID: <20260220041431.372610-1-s-vadapalli@ti.com> (raw)
Hello,
This series fixes the warning:
Unbalanced enable for IRQ ...
for the CPSW and ICSSG drivers.
Under heavy traffic and in an SMP environment the warning shows up after
a relatively long time. The issue occurs due to the order in which the
variable 'irq_disabled' is set and the function disable_irq_nosync() is
invoked.
I have examined other drivers and they follow the right order which is
to invoke disable_irq_nosync() before setting 'irq_disabled' (or its
equivalent variable).
The first patch is for the CPSW driver and it has two Fixes tags since
the code change associated with the fix is for a recent commit while
the incorrect order was first introduced by a much older commit.
The second and third patches are for the ICSSG driver. Although they
are both for the same driver and could be squashed, I chose to split
them since they fix different commits and need to be backported as
Fixes for the respective commits.
Regards,
Siddharth.
Siddharth Vadapalli (3):
net: ethernet: ti: am65-cpsw-nuss: set irq_disabled after disabling RX
IRQ
net: ethernet: ti: icssg_common: set irq_disabled after disabling TX
IRQ
net: ethernet: ti: icssg_common: set irq_disabled after disabling RX
IRQ
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +-
drivers/net/ethernet/ti/icssg/icssg_common.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
--
2.51.1
next reply other threads:[~2026-02-20 4:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 4:11 Siddharth Vadapalli [this message]
2026-02-20 4:11 ` [PATCH net 1/3] net: ethernet: ti: am65-cpsw-nuss: set irq_disabled after disabling RX IRQ Siddharth Vadapalli
2026-02-24 2:48 ` Jakub Kicinski
2026-02-24 5:10 ` Siddharth Vadapalli
2026-02-24 23:54 ` Jakub Kicinski
2026-02-25 11:12 ` Siddharth Vadapalli
2026-02-20 4:11 ` [PATCH net 2/3] net: ethernet: ti: icssg_common: set irq_disabled after disabling TX IRQ Siddharth Vadapalli
2026-02-24 2:48 ` Jakub Kicinski
2026-02-24 12:24 ` Siddharth Vadapalli
2026-02-24 23:49 ` Jakub Kicinski
2026-02-25 11:31 ` Siddharth Vadapalli
2026-02-26 0:09 ` Jakub Kicinski
2026-02-26 11:34 ` Siddharth Vadapalli
2026-02-20 4:11 ` [PATCH net 3/3] net: ethernet: ti: icssg_common: set irq_disabled after disabling RX IRQ Siddharth Vadapalli
2026-02-20 10:00 ` [PATCH net 0/3] Fix Unbalanced IRQ Enable for CPSW and ICSSG Malladi, Meghana
2026-02-23 17:39 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220041431.372610-1-s-vadapalli@ti.com \
--to=s-vadapalli@ti.com \
--cc=andrew+netdev@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-malladi@ti.com \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=mwalle@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=stable@vger.kernel.org \
--cc=v-singh1@ti.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox