public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] docs: net: document neigh gc_interval and gc_stale_time sysctls
@ 2026-02-19 16:21 Gabriel Goller
  2026-02-19 16:50 ` Keller, Jacob E
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Gabriel Goller @ 2026-02-19 16:21 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Simon Horman, Jonathan Corbet, Shuah Khan
  Cc: netdev, linux-doc, linux-kernel

Add missing documentation for two neighbor table garbage collector
sysctl parameters in ip-sysctl.rst:

 * neigh/default/gc_interval: controls how often the garbage collector
   runs for neighbor entries (default: 30 seconds)
 * neigh/default/gc_stale_time: controls how long an unused neighbor
   entry is kept before becoming eligible for garbage collection
   (default: 60 seconds)

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 Documentation/networking/ip-sysctl.rst | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
index 28c7e4f5ecf9..033e18303d79 100644
--- a/Documentation/networking/ip-sysctl.rst
+++ b/Documentation/networking/ip-sysctl.rst
@@ -202,6 +202,21 @@ neigh/default/gc_thresh3 - INTEGER
 
 	Default: 1024
 
+neigh/default/gc_interval - INTEGER
+	How often the garbage collector for neighbor entries should run. This
+	value applies to the entire table, not individual entries.
+
+	Default: 30 seconds
+
+neigh/default/gc_stale_time - INTEGER
+	Determines how long a neighbor entry can remain unused before it is
+	considered stale and eligible for garbage collection. Entries that have
+	not been used for longer than this time will be removed by the garbage
+	collector, unless they have active references, are marked as PERMANENT,
+	or carry the NTF_EXT_LEARNED or NTF_EXT_VALIDATED flag.
+
+	Default: 60 seconds
+
 neigh/default/unres_qlen_bytes - INTEGER
 	The maximum number of bytes which may be used by packets
 	queued for each	unresolved address by other network layers.
-- 
2.47.3



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* RE: [PATCH net-next] docs: net: document neigh gc_interval and gc_stale_time sysctls
  2026-02-19 16:21 [PATCH net-next] docs: net: document neigh gc_interval and gc_stale_time sysctls Gabriel Goller
@ 2026-02-19 16:50 ` Keller, Jacob E
  2026-02-21  0:43 ` Jakub Kicinski
  2026-02-23 10:23 ` Gabriel Goller
  2 siblings, 0 replies; 8+ messages in thread
From: Keller, Jacob E @ 2026-02-19 16:50 UTC (permalink / raw)
  To: Gabriel Goller, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Simon Horman, Jonathan Corbet, Shuah Khan
  Cc: netdev@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org



> -----Original Message-----
> From: Gabriel Goller <g.goller@proxmox.com>
> Sent: Thursday, February 19, 2026 8:22 AM
> To: David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; Simon Horman <horms@kernel.org>; Jonathan
> Corbet <corbet@lwn.net>; Shuah Khan <skhan@linuxfoundation.org>
> Cc: netdev@vger.kernel.org; linux-doc@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH net-next] docs: net: document neigh gc_interval and
> gc_stale_time sysctls
> 
> Add missing documentation for two neighbor table garbage collector
> sysctl parameters in ip-sysctl.rst:
> 
>  * neigh/default/gc_interval: controls how often the garbage collector
>    runs for neighbor entries (default: 30 seconds)
>  * neigh/default/gc_stale_time: controls how long an unused neighbor
>    entry is kept before becoming eligible for garbage collection
>    (default: 60 seconds)
> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---

Reviewed-by: Jacob Keller <Jacob.e.keller@intel.com>

>  Documentation/networking/ip-sysctl.rst | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/Documentation/networking/ip-sysctl.rst
> b/Documentation/networking/ip-sysctl.rst
> index 28c7e4f5ecf9..033e18303d79 100644
> --- a/Documentation/networking/ip-sysctl.rst
> +++ b/Documentation/networking/ip-sysctl.rst
> @@ -202,6 +202,21 @@ neigh/default/gc_thresh3 - INTEGER
> 
>  	Default: 1024
> 
> +neigh/default/gc_interval - INTEGER
> +	How often the garbage collector for neighbor entries should run. This
> +	value applies to the entire table, not individual entries.
> +
> +	Default: 30 seconds
> +
> +neigh/default/gc_stale_time - INTEGER
> +	Determines how long a neighbor entry can remain unused before it is
> +	considered stale and eligible for garbage collection. Entries that have
> +	not been used for longer than this time will be removed by the
> garbage
> +	collector, unless they have active references, are marked as
> PERMANENT,
> +	or carry the NTF_EXT_LEARNED or NTF_EXT_VALIDATED flag.
> +
> +	Default: 60 seconds
> +
>  neigh/default/unres_qlen_bytes - INTEGER
>  	The maximum number of bytes which may be used by packets
>  	queued for each	unresolved address by other network layers.
> --
> 2.47.3
> 
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next] docs: net: document neigh gc_interval and gc_stale_time sysctls
  2026-02-19 16:21 [PATCH net-next] docs: net: document neigh gc_interval and gc_stale_time sysctls Gabriel Goller
  2026-02-19 16:50 ` Keller, Jacob E
@ 2026-02-21  0:43 ` Jakub Kicinski
  2026-02-23  9:54   ` Gabriel Goller
  2026-02-23 10:23 ` Gabriel Goller
  2 siblings, 1 reply; 8+ messages in thread
From: Jakub Kicinski @ 2026-02-21  0:43 UTC (permalink / raw)
  To: Gabriel Goller
  Cc: David S. Miller, Eric Dumazet, Paolo Abeni, Simon Horman,
	Jonathan Corbet, Shuah Khan, netdev, linux-doc, linux-kernel

On Thu, 19 Feb 2026 17:21:58 +0100 Gabriel Goller wrote:
> +neigh/default/gc_interval - INTEGER
> +	How often the garbage collector for neighbor entries should run. This
> +	value applies to the entire table, not individual entries.
> +
> +	Default: 30 seconds

AI suggests that this value is not actually currently used
in our implementation. I can't find any use either, TBH.
It's read and can be written but it's seemingly not used for anything.

> +neigh/default/gc_stale_time - INTEGER
> +	Determines how long a neighbor entry can remain unused before it is
> +	considered stale and eligible for garbage collection. Entries that have
> +	not been used for longer than this time will be removed by the garbage
> +	collector, unless they have active references, are marked as PERMANENT,
> +	or carry the NTF_EXT_LEARNED or NTF_EXT_VALIDATED flag.
> +
> +	Default: 60 seconds

AI adds:

  Important caveat: This check is only reached when total_entries >= gc_thresh1
  (line 1000-1001). Below that threshold, the periodic GC skips the scan
  entirely.

If true I think we should mention that ?
-- 
pw-bot: cr

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next] docs: net: document neigh gc_interval and gc_stale_time sysctls
  2026-02-21  0:43 ` Jakub Kicinski
@ 2026-02-23  9:54   ` Gabriel Goller
  0 siblings, 0 replies; 8+ messages in thread
From: Gabriel Goller @ 2026-02-23  9:54 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: David S. Miller, Eric Dumazet, Paolo Abeni, Simon Horman,
	Jonathan Corbet, Shuah Khan, netdev, linux-doc, linux-kernel

On 20.02.2026 16:43, Jakub Kicinski wrote:
> On Thu, 19 Feb 2026 17:21:58 +0100 Gabriel Goller wrote:
> > +neigh/default/gc_interval - INTEGER
> > +	How often the garbage collector for neighbor entries should run. This
> > +	value applies to the entire table, not individual entries.
> > +
> > +	Default: 30 seconds
> 
> AI suggests that this value is not actually currently used
> in our implementation. I can't find any use either, TBH.
> It's read and can be written but it's seemingly not used for anything.

You're right, I'll remove this section.

> > +neigh/default/gc_stale_time - INTEGER
> > +	Determines how long a neighbor entry can remain unused before it is
> > +	considered stale and eligible for garbage collection. Entries that have
> > +	not been used for longer than this time will be removed by the garbage
> > +	collector, unless they have active references, are marked as PERMANENT,
> > +	or carry the NTF_EXT_LEARNED or NTF_EXT_VALIDATED flag.
> > +
> > +	Default: 60 seconds
> 
> AI adds:
> 
>   Important caveat: This check is only reached when total_entries >= gc_thresh1
>   (line 1000-1001). Below that threshold, the periodic GC skips the scan
>   entirely.
> 
> If true I think we should mention that ?

Yes this is true -- I'll mention this in the description.

Thanks for the review!



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next] docs: net: document neigh gc_interval and gc_stale_time sysctls
  2026-02-19 16:21 [PATCH net-next] docs: net: document neigh gc_interval and gc_stale_time sysctls Gabriel Goller
  2026-02-19 16:50 ` Keller, Jacob E
  2026-02-21  0:43 ` Jakub Kicinski
@ 2026-02-23 10:23 ` Gabriel Goller
  2026-02-23 22:58   ` Jakub Kicinski
  2 siblings, 1 reply; 8+ messages in thread
From: Gabriel Goller @ 2026-02-23 10:23 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Simon Horman, Jonathan Corbet, Shuah Khan
  Cc: netdev, linux-doc, linux-kernel

Superseded by:
- [PATCH net-next v2] docs: net: document neigh gc_stale_time sysctl
  https://lore.kernel.org/netdev/20260223101257.47563-1-g.goller@proxmox.com/

--
pw-bot: superseded



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next] docs: net: document neigh gc_interval and gc_stale_time sysctls
  2026-02-23 10:23 ` Gabriel Goller
@ 2026-02-23 22:58   ` Jakub Kicinski
  2026-02-24  9:06     ` Gabriel Goller
  0 siblings, 1 reply; 8+ messages in thread
From: Jakub Kicinski @ 2026-02-23 22:58 UTC (permalink / raw)
  To: Gabriel Goller
  Cc: David S. Miller, Eric Dumazet, Paolo Abeni, Simon Horman,
	Jonathan Corbet, Shuah Khan, netdev, linux-doc, linux-kernel

On Mon, 23 Feb 2026 11:23:29 +0100 Gabriel Goller wrote:
> Superseded by:
> - [PATCH net-next v2] docs: net: document neigh gc_stale_time sysctl
>   https://lore.kernel.org/netdev/20260223101257.47563-1-g.goller@proxmox.com/
> 
> --
> pw-bot: superseded

Where did you get the idea to send this email??

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next] docs: net: document neigh gc_interval and gc_stale_time sysctls
  2026-02-23 22:58   ` Jakub Kicinski
@ 2026-02-24  9:06     ` Gabriel Goller
  2026-02-25  0:01       ` Jakub Kicinski
  0 siblings, 1 reply; 8+ messages in thread
From: Gabriel Goller @ 2026-02-24  9:06 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: David S. Miller, Eric Dumazet, Paolo Abeni, Simon Horman,
	Jonathan Corbet, Shuah Khan, netdev, linux-doc, linux-kernel

On 23.02.2026 14:58, Jakub Kicinski wrote:
> On Mon, 23 Feb 2026 11:23:29 +0100 Gabriel Goller wrote:
> > Superseded by:
> > - [PATCH net-next v2] docs: net: document neigh gc_stale_time sysctl
> >   https://lore.kernel.org/netdev/20260223101257.47563-1-g.goller@proxmox.com/
> > 
> > --
> > pw-bot: superseded
> 
> Where did you get the idea to send this email??

Haha, I changed the title of the patch in the new version, so Patchwork
didn't automatically recognize it and mark the old one as superseded.

I saw in Documentation/process/maintainer-netdev.rst that there's a way
to manually set the state to superseded using pw-bot commands. However,
it turns out I don't have the necessary permissions to do that :)


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next] docs: net: document neigh gc_interval and gc_stale_time sysctls
  2026-02-24  9:06     ` Gabriel Goller
@ 2026-02-25  0:01       ` Jakub Kicinski
  0 siblings, 0 replies; 8+ messages in thread
From: Jakub Kicinski @ 2026-02-25  0:01 UTC (permalink / raw)
  To: Gabriel Goller
  Cc: David S. Miller, Eric Dumazet, Paolo Abeni, Simon Horman,
	Jonathan Corbet, Shuah Khan, netdev, linux-doc, linux-kernel

On Tue, 24 Feb 2026 10:06:41 +0100 Gabriel Goller wrote:
> On 23.02.2026 14:58, Jakub Kicinski wrote:
> > On Mon, 23 Feb 2026 11:23:29 +0100 Gabriel Goller wrote:  
> > > Superseded by:
> > > - [PATCH net-next v2] docs: net: document neigh gc_stale_time sysctl
> > >   https://lore.kernel.org/netdev/20260223101257.47563-1-g.goller@proxmox.com/
> > > 
> > > --
> > > pw-bot: superseded  
> > 
> > Where did you get the idea to send this email??  
> 
> Haha, I changed the title of the patch in the new version, so Patchwork
> didn't automatically recognize it and mark the old one as superseded.

Oh, that's nice of you! Would have been useful to mention the reason in
the email to avoid my grumbling :)

> I saw in Documentation/process/maintainer-netdev.rst that there's a way
> to manually set the state to superseded using pw-bot commands. However,
> it turns out I don't have the necessary permissions to do that :)

You should as the author, I think the issue is DKIM. Your email from the
archive fails DKIM verification, probably because headers were modified
to look like they were sent by the list? You can try to complain to
your email provider, most get it right.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-02-25  0:01 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-19 16:21 [PATCH net-next] docs: net: document neigh gc_interval and gc_stale_time sysctls Gabriel Goller
2026-02-19 16:50 ` Keller, Jacob E
2026-02-21  0:43 ` Jakub Kicinski
2026-02-23  9:54   ` Gabriel Goller
2026-02-23 10:23 ` Gabriel Goller
2026-02-23 22:58   ` Jakub Kicinski
2026-02-24  9:06     ` Gabriel Goller
2026-02-25  0:01       ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox