From: Jakub Kicinski <kuba@kernel.org>
To: "Björn Töpel" <bjorn@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, Donald Hunter <donald.hunter@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Michael Chan <michael.chan@broadcom.com>,
Hariprasad Kelam <hkelam@marvell.com>,
Ido Schimmel <idosch@nvidia.com>,
Danielle Ratson <danieller@nvidia.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [RFC net-next 0/4] ethtool: CMIS module diagnostic loopback support
Date: Mon, 23 Feb 2026 15:04:01 -0800 [thread overview]
Message-ID: <20260223150401.7993b11a@kernel.org> (raw)
In-Reply-To: <CAJ+HfNgXqpqDYsmAa-mpHnO82aDgC7XbyVw3TmXk-ySFmGA-JQ@mail.gmail.com>
On Sun, 22 Feb 2026 20:58:30 +0100 Björn Töpel wrote:
> /* Loopback layers/scope
> enum ethtool_loopback_layer {
> ETHTOOL_LB_LAYER_SW = 0, /* Software/Kernel stack loopback */
What would that be? :)
> ETHTOOL_LB_LAYER_MAC, /* MAC/Controller internal */
> ETHTOOL_LB_LAYER_PCS, /* Physical Coding Sublayer (Digital) */
> ETHTOOL_LB_LAYER_PMA, /* SerDes / Analog-Digital boundary */
> ETHTOOL_LB_LAYER_PMD, /* Transceiver / Module internal */
In my mind the "layer" was supposed to tell core which driver to send
the request to. Same concept is used in the timestamp source selection.
PCS/PMA/PMD is both too fine grained when you have multiple PHYs in the
path, and does not cover all the possible loopback points.
> ETHTOOL_LB_LAYER_EXT, /* External physical plug/cable */
is EXT used somewhere to mean SFP already?
next prev parent reply other threads:[~2026-02-23 23:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 13:00 [RFC net-next 0/4] ethtool: CMIS module diagnostic loopback support Björn Töpel
2026-02-19 13:00 ` [RFC net-next 1/4] ethtool: module: Define CMIS loopback YAML spec and UAPI Björn Töpel
2026-02-19 13:00 ` [RFC net-next 2/4] ethtool: module: Add CMIS loopback GET/SET support Björn Töpel
2026-02-19 15:59 ` Andrew Lunn
2026-02-19 13:00 ` [RFC net-next 3/4] ethtool: module: refactor fw flash init to reuse CMIS helpers Björn Töpel
2026-02-19 13:00 ` [RFC net-next 4/4] net/mlx5e: Implement set_module_eeprom_by_page ethtool callback Björn Töpel
2026-02-19 13:16 ` [RFC net-next 0/4] ethtool: CMIS module diagnostic loopback support Björn Töpel
2026-02-19 15:51 ` Andrew Lunn
2026-02-20 0:05 ` Jakub Kicinski
2026-02-20 14:18 ` Andrew Lunn
2026-02-20 21:12 ` Jakub Kicinski
2026-02-22 19:58 ` Björn Töpel
2026-02-23 14:30 ` Andrew Lunn
2026-02-23 14:41 ` Björn Töpel
2026-02-23 23:04 ` Jakub Kicinski [this message]
2026-02-24 10:28 ` Björn Töpel
2026-02-25 4:04 ` Andrew Lunn
2026-02-25 8:39 ` Björn Töpel
2026-02-25 13:14 ` Andrew Lunn
2026-03-02 9:00 ` Maxime Chevallier
2026-03-04 15:52 ` Björn Töpel
2026-03-04 16:09 ` Maxime Chevallier
2026-02-25 10:22 ` Maxime Chevallier
2026-02-25 11:20 ` Björn Töpel
2026-02-20 8:11 ` Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260223150401.7993b11a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=bjorn@kernel.org \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox