From: David Laight <david.laight.linux@gmail.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: Koen Vandeputte <koen.vandeputte@citymesh.com>,
oneukum@suse.com, andrew+netdev@lunn.ch,
Eric Dumazet <edumazet@google.com>,
kuba@kernel.org, pabeni@redhat.com,
netdev <netdev@vger.kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: commit 662dc80a5e86 breaks rmnet over usb
Date: Mon, 23 Feb 2026 15:13:58 +0000 [thread overview]
Message-ID: <20260223151358.0efc263d@pumpkin> (raw)
In-Reply-To: <95ccf5a6-975b-4543-80a3-595f1ee20543@redhat.com>
On Mon, 23 Feb 2026 15:08:41 +0100
Laurent Vivier <lvivier@redhat.com> wrote:
...
> It's weird to be able to set an MTU that is not supported by the hardware.
>
> To restore performance I think the rx_usb_size should be decoupled from MTU max in qmi_wwan.
A lot of 'usbnet' drivers support usb packets that contain multiple ethernet frames.
IIRC (I looked at this code quite a few years ago) some (all?) lie very badly
about the skb 'true_size' of receive packets - putting in the frame size
even though it is sat in 16kb+ of kernel memory.
In reality the driver want to receive the 'stream' of usb packets and
debatch it directly into ethernet frames without going though the 'urb'
buffers at all.
ISTR that would be possible with the xhci/usb3 hardware, but would be a
massive re-write of parts of the stack.
I was only trying (and I mean failing) to get 100M working reliably.
Project got canned for other reasons.
David
next prev parent reply other threads:[~2026-02-23 15:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 12:04 commit 662dc80a5e86 breaks rmnet over usb Koen Vandeputte
2026-02-23 14:08 ` Laurent Vivier
2026-02-23 15:13 ` David Laight [this message]
2026-02-25 7:19 ` Daniele Palmas
2026-02-25 7:48 ` Laurent Vivier
2026-02-25 11:04 ` Laurent Vivier
2026-02-25 14:14 ` Daniele Palmas
2026-02-26 1:01 ` Jakub Kicinski
2026-02-26 8:26 ` Daniele Palmas
2026-02-26 9:09 ` Laurent Vivier
2026-02-26 18:18 ` Daniele Palmas
2026-02-27 16:15 ` Daniele Palmas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260223151358.0efc263d@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=edumazet@google.com \
--cc=koen.vandeputte@citymesh.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox