From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jeremy Kerr <jk@codeconstruct.com.au>,
Matt Johnston <matt@codeconstruct.com.au>,
stable <stable@kernel.org>
Subject: [PATCH net] net: mctp: usb: properly drop the usb interface on probe error
Date: Mon, 23 Feb 2026 12:33:19 +0100 [thread overview]
Message-ID: <2026022319-turbofan-darkened-206d@gregkh> (raw)
When an error happens in mctp_usb_probe() the reference count on the usb
interface structure needs to be properly dropped as it was incremented
earlier in the function.
Cc: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: Matt Johnston <matt@codeconstruct.com.au>
Cc: stable <stable@kernel.org>
Assisted-by: gkh_clanker_2000
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/net/mctp/mctp-usb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mctp/mctp-usb.c b/drivers/net/mctp/mctp-usb.c
index ef860cfc629f..eef17ae89298 100644
--- a/drivers/net/mctp/mctp-usb.c
+++ b/drivers/net/mctp/mctp-usb.c
@@ -355,6 +355,7 @@ static int mctp_usb_probe(struct usb_interface *intf,
usb_free_urb(dev->tx_urb);
usb_free_urb(dev->rx_urb);
free_netdev(netdev);
+ usb_put_dev(dev->usbdev);
return rc;
}
--
2.53.0
next reply other threads:[~2026-02-23 11:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 11:33 Greg Kroah-Hartman [this message]
2026-02-24 1:41 ` [PATCH net] net: mctp: usb: properly drop the usb interface on probe error Jeremy Kerr
2026-02-24 1:50 ` Jeremy Kerr
2026-02-24 6:18 ` Greg Kroah-Hartman
2026-02-24 6:31 ` Jeremy Kerr
2026-02-25 14:35 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026022319-turbofan-darkened-206d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=jk@codeconstruct.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox