From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC29F36C596 for ; Mon, 23 Feb 2026 21:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883435; cv=none; b=tb1Z+WzS/9Rfgo7U0wjmx9ZvcoZLKPIzMiBCUFmJ4FkrBcMYBD6CsD5yNMznZIRy2jSS9X3Bmp+UpHAERmTC/sbcvxicPf0i4bI474bN0WRusLd0Cpgn/6IBAKXFVF7cgxrFf//64oMbU+V8/FLCLJSr278Yfgry8+DGi98du7k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883435; c=relaxed/simple; bh=dJIY/emjpr4sdLgCFoAYb5MbGHRNecbCpDwVHChAFLo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ObhMCmsQ55DSWAywiQI3aAPgprSkJsKgs0v+RQnpGRLx1Bp77faP5esuDqRz225mo24E12fbgTct0MU6FXOfcAPvJ9dXhKlI87EnUHICA9/ZVcJYE73LntQTD9Xdn21Glmggla9mXRRHA/hQVDmOmFTgTAZ6q/BvBcicGgQhKeE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=oCRRAMy1; arc=none smtp.client-ip=199.89.1.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="oCRRAMy1" Received: from localhost (localhost [127.0.0.1]) by 013.lax.mailroute.net (Postfix) with ESMTP id 4fKZKQ2hjQzlh2fB; Mon, 23 Feb 2026 21:50:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:mime-version:references:in-reply-to :x-mailer:message-id:date:date:subject:subject:from:from :received:received; s=mr01; t=1771883432; x=1774475433; bh=ANKdv tuiRf4C27SapojcPvyuhJhY2SUjvNwjDyRn5hU=; b=oCRRAMy1D4lcS7Zmhag2D FemoHiyypnYUheIvxFs7BiaF3cLjjD8OsqU2TU8ee2z2HD6mlDpD1puP0jQpfY2L 1LMsX2ycBfCwca6v0RTf0Sdi/44tpDtrI5RReIgJWNRaN4VTdeWpfPw03wWyv42W dNRi/WGevjqNADMmmLqbAet+aSRsTx2UVOAyeVurWC6FQwNE1cgino1ZMQNa2NAp VREa+e2V6t2d+Al4O00KkGP/6OdWSMrmPNorONbAgRCsX4X4e3ieQpIunjkHzp7W Oa8JNA/i94dOh4oNwRdf6QDQ/WxHgFfgzS742v1A3l3uO0RPtqWXTgxAorxbeEsj Q== X-Virus-Scanned: by MailRoute Received: from 013.lax.mailroute.net ([127.0.0.1]) by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id WgwScLXhapj1; Mon, 23 Feb 2026 21:50:32 +0000 (UTC) Received: from bvanassche.mtv.corp.google.com (unknown [104.135.180.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 013.lax.mailroute.net (Postfix) with ESMTPSA id 4fKZKK5xPSzlfddf; Mon, 23 Feb 2026 21:50:29 +0000 (UTC) From: Bart Van Assche To: Peter Zijlstra Cc: Bart Van Assche , Naveen Mamindlapalli , Jakub Kicinski , Sunil Goutham , Geetha sowjanya , Subbaraya Sundeep , hariprasad , Bharat Bhushan , netdev@vger.kernel.org Subject: [PATCH 20/62] octeontx2-pf: Fix locking in an error path Date: Mon, 23 Feb 2026 13:49:08 -0800 Message-ID: <20260223214950.2153735-21-bvanassche@acm.org> X-Mailer: git-send-email 2.53.0.371.g1d285c8824-goog In-Reply-To: <20260223214950.2153735-1-bvanassche@acm.org> References: <20260223214950.2153735-1-bvanassche@acm.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Only unlock pf->mbox.lock if it has been locked by otx2_do_set_vf_vlan(). This bug has been detected by the Clang thread-safety analyzer. Cc: Naveen Mamindlapalli Cc: Jakub Kicinski Cc: Sunil Goutham Cc: Geetha sowjanya Cc: Subbaraya Sundeep Cc: hariprasad Cc: Bharat Bhushan Cc: netdev@vger.kernel.org Fixes: f0c2982aaf98 ("octeontx2-pf: Add support for SR-IOV management fun= ctions") Signed-off-by: Bart Van Assche --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drive= rs/net/ethernet/marvell/octeontx2/nic/otx2_pf.c index ee623476e5ff..8c9f08ed90fd 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c @@ -2588,7 +2588,7 @@ static int otx2_do_set_vf_vlan(struct otx2_nic *pf,= int vf, u16 vlan, u8 qos, config =3D &pf->vf_configs[vf]; =20 if (!vlan && !config->vlan) - goto out; + return err; =20 mutex_lock(&pf->mbox.lock); =20