public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH iproute2] include/json_print.h: add includes for `__u32` and `timeval` declarations
@ 2026-02-23 22:34 Sergei Trofimovich
  2026-02-28  1:10 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Sergei Trofimovich @ 2026-02-23 22:34 UTC (permalink / raw)
  To: netdev; +Cc: Sergei Trofimovich

Without the change the build fails on `musl` as:

```
../include/json_print.h:100:44: error: unknown type name ‘__u32’
  100 | unsigned int print_range(const char *name, __u32 start, __u32 end);
      |                                            ^~~~~
...
../include/json_print.h:82:30: warning: ‘struct timeval’ declared inside parameter list will not be visible outside of this definition or declaration
   82 | _PRINT_FUNC(tv, const struct timeval *)
      |                              ^~~~~~~
../include/json_print.h:57:45: note: in definition of macro ‘_PRINT_FUNC’
   57 |                                             type value)                 \
      |                                             ^~~~
../include/json_print.h: In function ‘print_tv’:
../include/json_print.h:60:48: error: passing argument 5 of ‘print_color_tv’ from incompatible pointer type [-Wincompatible-pointer-types]
   60 |                                                value);                  \
      |                                                ^~~~~
      |                                                |
      |                                                const struct timeval *
```
---
 include/json_print.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/json_print.h b/include/json_print.h
index 59edd5b2..c0d6315f 100644
--- a/include/json_print.h
+++ b/include/json_print.h
@@ -8,6 +8,10 @@
 #ifndef _JSON_PRINT_H_
 #define _JSON_PRINT_H_
 
+#include <sys/time.h> /* struct timeval typedef */
+
+#include <asm/types.h> /* __u32 typedef */
+
 #include "json_writer.h"
 #include "color.h"
 
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH iproute2] include/json_print.h: add includes for `__u32` and `timeval` declarations
  2026-02-23 22:34 [PATCH iproute2] include/json_print.h: add includes for `__u32` and `timeval` declarations Sergei Trofimovich
@ 2026-02-28  1:10 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-02-28  1:10 UTC (permalink / raw)
  To: Sergei Trofimovich; +Cc: netdev

Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:

On Mon, 23 Feb 2026 22:34:35 +0000 you wrote:
> Without the change the build fails on `musl` as:
> 
> ```
> ../include/json_print.h:100:44: error: unknown type name ‘__u32’
>   100 | unsigned int print_range(const char *name, __u32 start, __u32 end);
>       |                                            ^~~~~
> ...
> ../include/json_print.h:82:30: warning: ‘struct timeval’ declared inside parameter list will not be visible outside of this definition or declaration
>    82 | _PRINT_FUNC(tv, const struct timeval *)
>       |                              ^~~~~~~
> ../include/json_print.h:57:45: note: in definition of macro ‘_PRINT_FUNC’
>    57 |                                             type value)                 \
>       |                                             ^~~~
> ../include/json_print.h: In function ‘print_tv’:
> ../include/json_print.h:60:48: error: passing argument 5 of ‘print_color_tv’ from incompatible pointer type [-Wincompatible-pointer-types]
>    60 |                                                value);                  \
>       |                                                ^~~~~
>       |                                                |
>       |                                                const struct timeval *
> ```
> 
> [...]

Here is the summary with links:
  - [iproute2] include/json_print.h: add includes for `__u32` and `timeval` declarations
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=987be6691510

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-02-28  1:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-23 22:34 [PATCH iproute2] include/json_print.h: add includes for `__u32` and `timeval` declarations Sergei Trofimovich
2026-02-28  1:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox