From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 350EA366546; Mon, 23 Feb 2026 12:59:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771851596; cv=none; b=mjoQaszzwuACCyhLNk5xVT5P7jXCyin907y+WxDy0rXY6tSLApMPe5kNHuwT+gDaApfC1camguqUv/sRo6xw5qWAK5Q6BVkZ4SOr4Cx7linIqSGRwriPirQSOw6vSlkEeRleDupWYoF6CpEn4/DL1GTDLnm257QYsw3I+Q029Ms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771851596; c=relaxed/simple; bh=hG5KVNioTFku1eR+EwLLVm3cnoXg/dKXvNBO8zGXors=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=V9ypur2Qu7S5O7LHuwP9rDsknT3H3y+WCPsDQwNVx/szvRjHrJu9j8I/G5Nrrw3d5r8eM+cs40iHh3szvX4HqOrEFmCKHHW1A7EfwH0gf/3U3H8dESg9FXwPfGTNcjzeh+nkje+IU/b5jr6tiXYy01UrM9V9E+4XOfij88pZPlg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nZbqregE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nZbqregE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9606C116C6; Mon, 23 Feb 2026 12:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1771851595; bh=hG5KVNioTFku1eR+EwLLVm3cnoXg/dKXvNBO8zGXors=; h=From:To:Cc:Subject:Date:From; b=nZbqregEc1A172hnKmyPePgm/qHI4ZoU2q+tXVm95Vm4Xy8rV0az2uEXWN8JAfNqX hjNuZKPYzpUgyPwA8/XMRvrinab+p+YKrS2Da8yxyTzCbIMXNu0VyjGGAvVWzy3IIO kcRNrBtEH89qu11rp/JvB3UdbjFNlvW4eSAVFwnU= From: Greg Kroah-Hartman To: netdev@vger.kernel.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , stable Subject: [PATCH] net: usb: kalmia: validate USB endpoints Date: Mon, 23 Feb 2026 13:59:26 +0100 Message-ID: <2026022326-shack-headstone-ef6f@gregkh> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1281; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=hG5KVNioTFku1eR+EwLLVm3cnoXg/dKXvNBO8zGXors=; b=owGbwMvMwCRo6H6F97bub03G02pJDJlz/PWSi+uW2KYap7+a8F6vM74mwKYs4Gmtisr9V1d+7 J2VY7WqI5aFQZCJQVZMkeXLNp6j+ysOKXoZ2p6GmcPKBDKEgYtTACZy7TTDgrPmjMGz2ZOCg0s7 /J+WHAu6fUNQj2G+R9gqd52lzypWz5p+YOnjk463vaM4AA== X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit The kalmia driver should validate that the device it is probing has the proper number and types of USB endpoints it is expecting before it binds to it. If a malicious device were to not have the same urbs the driver will crash later on when it blindly accesses these endpoints. Cc: stable Assisted-by: gkh_clanker_2000 Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/kalmia.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/usb/kalmia.c b/drivers/net/usb/kalmia.c index 613fc6910f14..ee9c48f7f68f 100644 --- a/drivers/net/usb/kalmia.c +++ b/drivers/net/usb/kalmia.c @@ -132,11 +132,18 @@ kalmia_bind(struct usbnet *dev, struct usb_interface *intf) { int status; u8 ethernet_addr[ETH_ALEN]; + static const u8 ep_addr[] = { + 1 | USB_DIR_IN, + 2 | USB_DIR_OUT, + 0}; /* Don't bind to AT command interface */ if (intf->cur_altsetting->desc.bInterfaceClass != USB_CLASS_VENDOR_SPEC) return -EINVAL; + if (!usb_check_bulk_endpoints(intf, ep_addr)) + return -ENODEV; + dev->in = usb_rcvbulkpipe(dev->udev, 0x81 & USB_ENDPOINT_NUMBER_MASK); dev->out = usb_sndbulkpipe(dev->udev, 0x02 & USB_ENDPOINT_NUMBER_MASK); dev->status = NULL; -- 2.53.0