* [PATCH net-next] net: fs_enet: allow nvmem to override MAC address
@ 2026-02-24 1:46 Rosen Penev
2026-02-24 8:29 ` Christophe Leroy (CS GROUP)
2026-02-26 3:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Rosen Penev @ 2026-02-24 1:46 UTC (permalink / raw)
To: netdev
Cc: Pantelis Antoniou, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni,
open list:FREESCALE SOC FS_ENET DRIVER, open list
NVMEM typically loads after the ethernet driver and
of_get_ethdev_address returns -EPROBE_DEFER. return in such a case to
allow NVMEM to work.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
index 2cbcc29408e3..d3c772ed5fc9 100644
--- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
+++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
@@ -951,7 +951,9 @@ static int fs_enet_probe(struct platform_device *ofdev)
spin_lock_init(&fep->lock);
spin_lock_init(&fep->tx_lock);
- of_get_ethdev_address(ofdev->dev.of_node, ndev);
+ ret = of_get_ethdev_address(ofdev->dev.of_node, ndev);
+ if (ret == -EPROBE_DEFER)
+ goto out_cleanup_data;
ret = fep->ops->allocate_bd(ndev);
if (ret)
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: fs_enet: allow nvmem to override MAC address
2026-02-24 1:46 [PATCH net-next] net: fs_enet: allow nvmem to override MAC address Rosen Penev
@ 2026-02-24 8:29 ` Christophe Leroy (CS GROUP)
2026-02-24 8:58 ` Rosen Penev
2026-02-26 3:10 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Christophe Leroy (CS GROUP) @ 2026-02-24 8:29 UTC (permalink / raw)
To: Rosen Penev, netdev
Cc: Pantelis Antoniou, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni,
open list:FREESCALE SOC FS_ENET DRIVER, open list
Le 24/02/2026 à 02:46, Rosen Penev a écrit :
> NVMEM typically loads after the ethernet driver and
> of_get_ethdev_address returns -EPROBE_DEFER. return in such a case to
> allow NVMEM to work.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> index 2cbcc29408e3..d3c772ed5fc9 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> @@ -951,7 +951,9 @@ static int fs_enet_probe(struct platform_device *ofdev)
> spin_lock_init(&fep->lock);
> spin_lock_init(&fep->tx_lock);
>
> - of_get_ethdev_address(ofdev->dev.of_node, ndev);
> + ret = of_get_ethdev_address(ofdev->dev.of_node, ndev);
> + if (ret == -EPROBE_DEFER)
> + goto out_cleanup_data;
What about other error cases ? Shouldn't it exit on all types of errors ?
>
> ret = fep->ops->allocate_bd(ndev);
> if (ret)
> --
> 2.53.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: fs_enet: allow nvmem to override MAC address
2026-02-24 8:29 ` Christophe Leroy (CS GROUP)
@ 2026-02-24 8:58 ` Rosen Penev
0 siblings, 0 replies; 4+ messages in thread
From: Rosen Penev @ 2026-02-24 8:58 UTC (permalink / raw)
To: Christophe Leroy (CS GROUP)
Cc: netdev, Pantelis Antoniou, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni,
open list:FREESCALE SOC FS_ENET DRIVER, open list
On Tue, Feb 24, 2026 at 12:29 AM Christophe Leroy (CS GROUP)
<chleroy@kernel.org> wrote:
>
>
>
> Le 24/02/2026 à 02:46, Rosen Penev a écrit :
> > NVMEM typically loads after the ethernet driver and
> > of_get_ethdev_address returns -EPROBE_DEFER. return in such a case to
> > allow NVMEM to work.
> >
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > ---
> > drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> > index 2cbcc29408e3..d3c772ed5fc9 100644
> > --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> > +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> > @@ -951,7 +951,9 @@ static int fs_enet_probe(struct platform_device *ofdev)
> > spin_lock_init(&fep->lock);
> > spin_lock_init(&fep->tx_lock);
> >
> > - of_get_ethdev_address(ofdev->dev.of_node, ndev);
> > + ret = of_get_ethdev_address(ofdev->dev.of_node, ndev);
> > + if (ret == -EPROBE_DEFER)
> > + goto out_cleanup_data;
>
> What about other error cases ? Shouldn't it exit on all types of errors ?
For MAC acquisition? No. That would result in a non working interface
for no good reason.
The way other driver handle this is exit when probe is deferred, and
set a random MAC on other errors.
>
> >
> > ret = fep->ops->allocate_bd(ndev);
> > if (ret)
> > --
> > 2.53.0
> >
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: fs_enet: allow nvmem to override MAC address
2026-02-24 1:46 [PATCH net-next] net: fs_enet: allow nvmem to override MAC address Rosen Penev
2026-02-24 8:29 ` Christophe Leroy (CS GROUP)
@ 2026-02-26 3:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-02-26 3:10 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, pantelis.antoniou, andrew+netdev, davem, edumazet, kuba,
pabeni, linuxppc-dev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 23 Feb 2026 17:46:06 -0800 you wrote:
> NVMEM typically loads after the ethernet driver and
> of_get_ethdev_address returns -EPROBE_DEFER. return in such a case to
> allow NVMEM to work.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> [...]
Here is the summary with links:
- [net-next] net: fs_enet: allow nvmem to override MAC address
https://git.kernel.org/netdev/net-next/c/dc2a1facbde8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-26 3:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-24 1:46 [PATCH net-next] net: fs_enet: allow nvmem to override MAC address Rosen Penev
2026-02-24 8:29 ` Christophe Leroy (CS GROUP)
2026-02-24 8:58 ` Rosen Penev
2026-02-26 3:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox