From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBEAC1EFFB7 for ; Wed, 25 Feb 2026 00:22:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771978925; cv=none; b=b6fWxylDhQB7w/pwn1KawbmBoI5FlzpCY4oS+wcS6UIJ1F6ZLpuc1b1gKfLIJNVkMttoHOaHLQkAOwEeU9RpBbsLABkidzqtDAZCK5WSA7qq2qqJ2aq9feOtRKmoBQyo7e72OI6Pk+e1eQxYY5suPAT1dRr7V8PzTM+zV358Shg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771978925; c=relaxed/simple; bh=ynS84/0PMmxwKi16uvPa1XSyB0im66wxPhqSCK6S0ds=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=biNOO8KOCzAODv8Hd6zDV6/PSW2ntbfWXn9zsDzOytA1eJp4BqHDyEzIbnG/eYLj80fMnunCOhXlIUwa2C6aR4iMMfPJEg0H4adg2yp+1dqHiMm2ISv/vqg1we05FjWo0Me3HM91uh1TdMHsKbkcmOqwSzO9brr/Ygk8Dd2bUQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ge0AiJIv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ge0AiJIv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8666EC116D0; Wed, 25 Feb 2026 00:22:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771978925; bh=ynS84/0PMmxwKi16uvPa1XSyB0im66wxPhqSCK6S0ds=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ge0AiJIvBbl8tSOzxzpG6pDDxdakdYHxj/SGqI3iokbedOLglImYp+KS38hGNLx0a aM4z068jN6vU+r6rQx96V354L/n0avRsXMP61aiek7Wk/sTQI/b/qtcaYXPMNI4jIj pUvPi6m8MfYfGpMMgEMs1mEvyNGFgZsjTHt2fO9tuWmafIKW9JNw94xJZSonkwZQhO N7N+6eS2Ypj6Qedc00oqWRi1T7HC9ThxHiXUEdpSGv68DZ7fIpzGbprS9+eBwESEDG WBdNBdDQRHLx2jz2FBUpPSykRhJDOHutCVc2UfCQYFN0Xags6ULJmM8vzqnJm5JvDH ICcFRdvLF48gQ== Date: Tue, 24 Feb 2026 16:22:03 -0800 From: Jakub Kicinski To: Riana Tauro Cc: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, aravind.iddamsetty@linux.intel.com, anshuman.gupta@intel.com, rodrigo.vivi@intel.com, joonas.lahtinen@linux.intel.com, simona.vetter@ffwll.ch, airlied@gmail.com, pratik.bari@intel.com, joshua.santosh.ranjan@intel.com, ashwin.kumar.kulkarni@intel.com, shubham.kumar@intel.com, ravi.kishore.koppuravuri@intel.com, raag.jadav@intel.com, anvesh.bakwad@intel.com, Zack McKevitt , Lijo Lazar , Hawking Zhang , "David S. Miller" , Paolo Abeni , Eric Dumazet , netdev@vger.kernel.org Subject: Re: [PATCH v8 1/5] drm/ras: Introduce the DRM RAS infrastructure over generic netlink Message-ID: <20260224162203.279f7b74@kernel.org> In-Reply-To: <20260223060541.526397-8-riana.tauro@intel.com> References: <20260223060541.526397-7-riana.tauro@intel.com> <20260223060541.526397-8-riana.tauro@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 23 Feb 2026 11:35:41 +0530 Riana Tauro wrote: > From: Rodrigo Vivi > > Introduces the DRM RAS infrastructure over generic netlink. > > The new interface allows drivers to expose RAS nodes and their > associated error counters to userspace in a structured and extensible > way. Each drm_ras node can register its own set of error counters, which > are then discoverable and queryable through netlink operations. This > lays the groundwork for reporting and managing hardware error states > in a unified manner across different DRM drivers. Family itself LGTM. I'm getting this diff when running regen: diff --git a/drivers/gpu/drm/drm_ras_nl.c b/drivers/gpu/drm/drm_ras_nl.c index 4714a574a143..8bc85eab751f 100644 --- a/drivers/gpu/drm/drm_ras_nl.c +++ b/drivers/gpu/drm/drm_ras_nl.c @@ -7,6 +7,8 @@ #include #include +#include "drm_ras_nl.h" + #include #include Is there a reason why drm_ras_nl.h is in the global include/ path and not in drivers/gpu/drm/, directly? This header is meant to be used just between the generated C code (which is mostly structs at this point) and the C source implementing the family. We haven't had any use case which would require making it global so generator doesn't support that. The source needs to be clean after regen, so we either need to move the header in this patch or I can send you a patch to add a new generator feature to override the header location. LMK.