From: Jakub Kicinski <kuba@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
netdev@vger.kernel.org,
Pantelis Antoniou <pantelis.antoniou@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH net] net: fs_enet: add missing kfree in _remove
Date: Tue, 24 Feb 2026 17:59:28 -0800 [thread overview]
Message-ID: <20260224175928.3d16350b@kernel.org> (raw)
In-Reply-To: <CAKxU2N8pedieviayis9CoRtm7z0S2C_f-pC1N0uoU0--4cXFSA@mail.gmail.com>
On Tue, 24 Feb 2026 14:24:53 -0800 Rosen Penev wrote:
> > Le 24/02/2026 à 02:55, Rosen Penev a écrit :
> > > The kfree is present in _probe on failure but not in remove.
> >
> > Which kfree ? Which structure ?
> probe has
>
> out_free_bd:
> fep->ops->free_bd(ndev);
> out_cleanup_data:
> fep->ops->cleanup_data(ndev);
> out_phylink:
> phylink_destroy(fep->phylink);
> out_free_dev:
> free_netdev(ndev);
> out_free_fpi:
> kfree(fpi);
This says fpi, not fep. Which is what Christophe was telling you.
Please add a Fixes tag when you send v2
prev parent reply other threads:[~2026-02-25 1:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 1:55 [PATCH net] net: fs_enet: add missing kfree in _remove Rosen Penev
2026-02-24 8:20 ` Christophe Leroy (CS GROUP)
2026-02-24 22:24 ` Rosen Penev
2026-02-25 1:59 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224175928.3d16350b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chleroy@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pantelis.antoniou@gmail.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox