From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E94253A1A54 for ; Wed, 25 Feb 2026 12:52:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772023956; cv=none; b=NC+c0lp0MotOiP0/t0GVkOCQwcGuBd9fOdPk82rRazaluQVn5J8R7lY2lIRLcU4bC1aeQH6AMv9uUoIvgZooMnhYrG9ZP1IDgpfBE/OuJXfbig+eKZd48z1VFYbmy8tBpp4FPLCq9t4NVSgArC/1qCkb7o1uYYPMRk6/Zo9ZMts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772023956; c=relaxed/simple; bh=sbLghi1wvhV55htoTSopKocdqh5GgtgNJsPIzD/S08U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YCjlYU+kXaJgp7YY+ID67qdIQy1ISKFqt1Ap/mKbSHJwxU/qVZupMKrZfoK90K3Ye3NRpcyGtrUsvwwGKxWVvOgZE2CFqU9E1Ojlzd60/myFlzlaJeefC/VoMdZYB8Ksba0CRzbwW1vqXQxTy+hkbH5hbROn6/cnf2f4gbKijyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=H/jnmIp9; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=C+AVtEuv; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="H/jnmIp9"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="C+AVtEuv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772023954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sbLghi1wvhV55htoTSopKocdqh5GgtgNJsPIzD/S08U=; b=H/jnmIp9KWXJF1hoRqr/6qY9Yi35DdkLCtUnOb9ML0NBRX2rh6i/cIHVxEpH+EhFN3jzUn XvnxufnaVkrvg/bIL3L02PdmeTYhSrwRincTHLDHzGx64nhNawCkT52DxBfVmo1LHmviql brQzqNMujfA4SiQNKjDRzgpu51+MCcc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-7n3QZX82P9yP99B1Obnsww-1; Wed, 25 Feb 2026 07:52:32 -0500 X-MC-Unique: 7n3QZX82P9yP99B1Obnsww-1 X-Mimecast-MFC-AGG-ID: 7n3QZX82P9yP99B1Obnsww_1772023951 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4398ad5d81dso964123f8f.0 for ; Wed, 25 Feb 2026 04:52:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772023951; x=1772628751; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sbLghi1wvhV55htoTSopKocdqh5GgtgNJsPIzD/S08U=; b=C+AVtEuvhN/yqV+KCJ0c9eKDkXPwdZiBspYhJqIw1WvaFABClB+3h0bRrAHAXK+qpw ZKft9xaQtkAv9qNVW9wtx5sNPAxv1stodw/LEL01HWowkiVJi6WbxPxVs9CjzbZukUZw 7z5RouNRB0iXqURt46VG/isCeJsEhRyGZFyd2rBoTg0G8CwnsIPCrWBedU2aSxnFsl/s pL8q0ocy4zNHV4hwENDWOc0jJt2l7LsGwNofaWAHfE5crnpTRcxSXuEjQJUPdEx/OGRe TLYSsOj11ks8d3PiOYLIhcfX42Ora5Db1bNVB3DBBdhwSu3vxeyP4nyYQDxsTRMMCStm fcgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772023951; x=1772628751; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sbLghi1wvhV55htoTSopKocdqh5GgtgNJsPIzD/S08U=; b=EurhkI6hgIQjSdn4gEXJCqR5KN2zYuGFMRcqaNKkjq9h6W7uG2kCRgPDCyqHR1j2T6 GYE2zzNw0XzD5gGCZPjnTKyIaa5/xIPfXUKNpm2LxvTqfOj/AMUV2e1vc/nPrwMHzztK 8JfMNIBVc10Jh0hTRn77QrBYBcGMauddw01BfQe8azEbVHcnjHk1ZiilnTPzsss3wt61 /loyhEwbT3om5jSZlsJkkO1VCI4y5gcJEQkhFhE4ROf1T0a5UatixT2EGNZtV11qBHyU dOzrys9Gmi53vIKgaU4dJLTG31NaF3SwWoo6aTvRM5zpZRfjqTXXF4y1OutEvp5Ej+zS qu2A== X-Gm-Message-State: AOJu0YyhinO/Yc4fHozdPoT/6fUBiO7NukbieORSneEOT8mBITdHadl2 FWWom+ygaOPlZqV6MAkjyrFE2yu/21i5ydnlONYQZN4/X35ZKdCu3BScOJlfHXY1rW/TFWL3FN+ xWnQ+FdPJCOg3VDffDdI2MJGHG/qdJL6uZlgYeqsTpe7s6fKA2Cx6eHZjbQ== X-Gm-Gg: ATEYQzym9D7uDx5eWTimj2g90xvkgWGrGxMtFLr1r+zrASwq+iF00E/ecWd2v6PBzyh pBp/ss0APrhKigtRB4OfwO4093EBLpof9FmWut9Ah0n7e/U7uS4meXdn8DgwTB7eZJASKjXkZlP THA+L1OgJ6EHETCWw99owa26IdzT2otDLXJZuiuzrP47cIUs+KMfClRqa8JyC/b/5OcTJDUpnQb joWL4aDHjvjw1IoUuQkCW7CG1iMTsjHqkEeIW5ChNzAzaK/j7+kYsVfOPE/r9OJ7KvjIR4UKUSe vGgzHiuDgtLju+Oop7odutIQEPGX+NoY7PQ/6b1yUmvfV6Uf0CWCQVgLsYy9lOg/34s0in8kZYZ FoSn+5s8f5aYtPJq3s5ElgFjiGVVM1jFq7+twQy36YgsNfw== X-Received: by 2002:a05:6000:2489:b0:437:6d3f:a04c with SMTP id ffacd0b85a97d-439942f9b28mr660659f8f.39.1772023951413; Wed, 25 Feb 2026 04:52:31 -0800 (PST) X-Received: by 2002:a05:6000:2489:b0:437:6d3f:a04c with SMTP id ffacd0b85a97d-439942f9b28mr660608f8f.39.1772023950927; Wed, 25 Feb 2026 04:52:30 -0800 (PST) Received: from redhat.com (IGLD-80-230-79-166.inter.net.il. [80.230.79.166]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439899da8dbsm10508920f8f.18.2026.02.25.04.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 04:52:30 -0800 (PST) Date: Wed, 25 Feb 2026 07:52:27 -0500 From: "Michael S. Tsirkin" To: Srujana Challa Cc: "netdev@vger.kernel.org" , "virtualization@lists.linux.dev" , "pabeni@redhat.com" , "jasowang@redhat.com" , "xuanzhuo@linux.alibaba.com" , "eperezma@redhat.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , Nithin Kumar Dabilpuram , Shiva Shankar Kommula , "stable@vger.kernel.org" Subject: Re: [EXTERNAL] Re: [PATCH net,v4,1/2] virtio_net: Improve RSS key size validation and use NETDEV_RSS_KEY_LEN Message-ID: <20260225075144-mutt-send-email-mst@kernel.org> References: <20260224065850.962826-1-schalla@marvell.com> <20260225050154-mutt-send-email-mst@kernel.org> <20260225072355-mutt-send-email-mst@kernel.org> <20260225073537-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Feb 25, 2026 at 12:47:02PM +0000, Srujana Challa wrote: > > I don't know what to tell you. rss_max_key_size is just the max device > > supports. driver should be free to use a smaller size. > My understanding is that this patch prevents the probe from failing by disabling the feature instead. > Given the current implementation, the driver becomes unusable when this condition is hit. current implementation even more broken. but the real fix is to intepret max key size as max.