From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable <stable@kernel.org>
Subject: Re: [PATCH net] nfc: pn533: properly drop the usb interface reference on disconnect
Date: Wed, 25 Feb 2026 06:31:12 -0800 [thread overview]
Message-ID: <2026022536-douche-concert-544a@gregkh> (raw)
In-Reply-To: <aZ1sjK3LwiLDt4F2@horms.kernel.org>
On Tue, Feb 24, 2026 at 09:17:00AM +0000, Simon Horman wrote:
> On Mon, Feb 23, 2026 at 12:28:30PM +0100, Greg Kroah-Hartman wrote:
> > When the device is disconnected from the driver, there is a "dangling"
> > reference count on the usb interface that was grabbed in the probe
> > callback. Fix this up by properly dropping the reference after we are
> > done with it.
> >
> > Cc: stable <stable@kernel.org>
> > Assisted-by: gkh_clanker_2000
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Hi Greg,
>
> As a fix, a Fixes tag seems appropriate.
> This seems to have been there since the beginning, so perhaps this one:
>
> Fixes: c46ee38620a2 ("NFC: pn533: add NXP pn533 nfc device driver")
Fair enough, I don't normally add Fixes: tags for my stuff as it's me
doing the backports to stable kernels once they hit Linus's tree :)
> That notwithstanding, this looks good to me.
>
> Reviewed-by: Simon Horman <horms@kernel.org>
thanks for the review!
greg k-h
next prev parent reply other threads:[~2026-02-25 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 11:28 [PATCH net] nfc: pn533: properly drop the usb interface reference on disconnect Greg Kroah-Hartman
2026-02-24 9:17 ` Simon Horman
2026-02-25 14:31 ` Greg Kroah-Hartman [this message]
2026-02-25 18:57 ` Simon Horman
2026-02-25 1:42 ` Jakub Kicinski
2026-02-25 14:30 ` Greg Kroah-Hartman
2026-02-26 3:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026022536-douche-concert-544a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox