Re: [net-next,3/9] ipvs: use single svc table

[Jakub Kicinski <kuba@kernel.org>]

This is an AI-generated review of your patch. The human sending this
email says "FYI"

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
ipvs: use single svc table

This patch merges fwmark based services and non-fwmark based services
into a single service table, eliminating the separate svc_fwm_table and
reducing the complexity of managing two hash tables.

> diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
> index 074a204ec6db..b5a5a5efe3cc 100644
> --- a/include/net/ip_vs.h
> +++ b/include/net/ip_vs.h

[ ... ]

> @@ -1050,10 +1049,7 @@ struct netns_ipvs {
>
>  	/* the service mutex that protect svc_table and svc_fwm_table */
                                                              ^^^^^^^^^^^^^^
>  	struct mutex service_mutex;
> -	/* the service table hashed by <protocol, addr, port> */
> -	struct hlist_head svc_table[IP_VS_SVC_TAB_SIZE];
> -	/* the service table hashed by fwmark */
> -	struct hlist_head svc_fwm_table[IP_VS_SVC_TAB_SIZE];
> +	struct hlist_head svc_table[IP_VS_SVC_TAB_SIZE];	/* Services */

Should this comment be updated to reflect the removal of svc_fwm_table?
The comment still references both svc_table and svc_fwm_table, but this
patch removes svc_fwm_table entirely. Perhaps it should read "protect
svc_table" instead.

[ ... ]