public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicolai Buchwitz <nb@tipi-net.de>
To: netdev@vger.kernel.org
Cc: andrew+netdev@lunn.ch, claudiu.beznea@tuxon.dev,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	nicolas.ferre@microchip.com, pabeni@redhat.com,
	linux@armlinux.org.uk, theo.lebrun@bootlin.com,
	rmk+kernel@armlinux.org.uk, phil@raspberrypi.com,
	Nicolai Buchwitz <nb@tipi-net.de>
Subject: [PATCH net-next v4 3/4] net: cadence: macb: add ethtool EEE support
Date: Thu, 26 Feb 2026 10:06:07 +0100	[thread overview]
Message-ID: <20260226090608.54802-4-nb@tipi-net.de> (raw)
In-Reply-To: <20260226090608.54802-1-nb@tipi-net.de>

Implement get_eee and set_eee ethtool ops for GEM, delegating to
phylink_ethtool_get_eee() and phylink_ethtool_set_eee(). Both
handlers return -EOPNOTSUPP when MACB_CAPS_EEE is absent, keeping
the ops safe to register unconditionally in gem_ethtool_ops.

Phylink owns the full EEE lifecycle: PHY advertisement, link
partner negotiation, timer management and ethtool state; the MAC
driver only provides the mac_enable_tx_lpi / mac_disable_tx_lpi
callbacks wired up in the previous patch.

Reviewed-by: Théo Lebrun <theo.lebrun@bootlin.com>
Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
---
 drivers/net/ethernet/cadence/macb_main.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 6b9c63195970..a7e00b99e9a8 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4034,6 +4034,26 @@ static const struct ethtool_ops macb_ethtool_ops = {
 	.set_ringparam		= macb_set_ringparam,
 };
 
+static int macb_get_eee(struct net_device *dev, struct ethtool_keee *eee)
+{
+	struct macb *bp = netdev_priv(dev);
+
+	if (!(bp->caps & MACB_CAPS_EEE))
+		return -EOPNOTSUPP;
+
+	return phylink_ethtool_get_eee(bp->phylink, eee);
+}
+
+static int macb_set_eee(struct net_device *dev, struct ethtool_keee *eee)
+{
+	struct macb *bp = netdev_priv(dev);
+
+	if (!(bp->caps & MACB_CAPS_EEE))
+		return -EOPNOTSUPP;
+
+	return phylink_ethtool_set_eee(bp->phylink, eee);
+}
+
 static const struct ethtool_ops gem_ethtool_ops = {
 	.get_regs_len		= macb_get_regs_len,
 	.get_regs		= macb_get_regs,
@@ -4055,6 +4075,8 @@ static const struct ethtool_ops gem_ethtool_ops = {
 	.get_rxnfc			= gem_get_rxnfc,
 	.set_rxnfc			= gem_set_rxnfc,
 	.get_rx_ring_count		= gem_get_rx_ring_count,
+	.get_eee		= macb_get_eee,
+	.set_eee		= macb_set_eee,
 };
 
 static int macb_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
-- 
2.51.0


  parent reply	other threads:[~2026-02-26  9:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26  9:06 [PATCH net-next v4 0/4] net: cadence: macb: add IEEE 802.3az EEE support Nicolai Buchwitz
2026-02-26  9:06 ` [PATCH net-next v4 1/4] net: cadence: macb: add EEE LPI statistics counters Nicolai Buchwitz
2026-02-26  9:06 ` [PATCH net-next v4 2/4] net: cadence: macb: implement EEE TX LPI support Nicolai Buchwitz
2026-02-28 13:33   ` Claudiu Beznea
2026-02-28 13:35     ` Claudiu Beznea
2026-02-26  9:06 ` Nicolai Buchwitz [this message]
2026-02-26 19:20   ` [PATCH net-next v4 3/4] net: cadence: macb: add ethtool EEE support Russell King (Oracle)
2026-02-26  9:06 ` [PATCH net-next v4 4/4] net: cadence: macb: enable EEE for Raspberry Pi RP1 Nicolai Buchwitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260226090608.54802-4-nb@tipi-net.de \
    --to=nb@tipi-net.de \
    --cc=andrew+netdev@lunn.ch \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=pabeni@redhat.com \
    --cc=phil@raspberrypi.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=theo.lebrun@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox