From: Hangbin Liu <liuhangbin@gmail.com>
To: netdev@vger.kernel.org
Cc: Jay Vosburgh <jv@jvosburgh.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sridhar Samudrala <sridhar.samudrala@intel.com>,
Jiri Pirko <jiri@resnulli.us>, Simon Horman <horms@kernel.org>,
Nikolay Aleksandrov <razor@blackwall.org>,
Ido Schimmel <idosch@nvidia.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Kuniyuki Iwashima <kuniyu@google.com>,
Samiullah Khawaja <skhawaja@google.com>,
Ahmed Zaki <ahmed.zaki@intel.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
linux-kernel@vger.kernel.org, bridge@lists.linux.dev,
Hangbin Liu <liuhangbin@gmail.com>
Subject: [RFC PATCH net-next 0/3] net: add ndo_update_offloads for offload computation
Date: Thu, 26 Feb 2026 11:42:05 +0000 [thread overview]
Message-ID: <20260226114208.27774-1-liuhangbin@gmail.com> (raw)
Currently, master devices (bonding, bridge, team) manually call
netdev_compute_master_upper_features() scattered throughout their port
add/remove operations. This approach requires each driver to remember
to update features at the right times and leads to code duplication.
The series adds a new ndo_update_offloads callback that is automatically
invoked during feature updates when upper/lower device relationships change.
This centralizes the feature computation flow and removes the burden
from individual drivers.
Changes:
1. Patch 1: Add ndo_update_offloads callback to net_device_ops and invoke
it from __netdev_update_features()
2. Patch 2: Convert bonding, bridge, and team drivers to use the new
callback, removing manual feature computation calls
3. Patch 3: Convert net_failover driver, significantly simplifying its
feature management code
*Discuss*:
1. Should we set ndo_update_offloads after ndo_set_features? Or maybe just
call netdev_compute_master_upper_features() in ndo_set_features?
2. Do we need to compute the offload feature for hsr?
Hangbin Liu (3):
net: add ndo_update_offloads
net: use ndo_update_offloads for bonding/bridge/team
failover: use .ndo_update_offloads for failover
drivers/net/bonding/bond_main.c | 10 ++++--
drivers/net/net_failover.c | 64 ++++-----------------------------
drivers/net/team/team_core.c | 11 +++---
include/linux/netdevice.h | 7 ++++
include/net/net_failover.h | 7 ----
net/bridge/br_device.c | 6 ++++
net/bridge/br_if.c | 4 ---
net/core/dev.c | 11 ++++--
8 files changed, 42 insertions(+), 78 deletions(-)
--
2.50.1
next reply other threads:[~2026-02-26 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 11:42 Hangbin Liu [this message]
2026-02-26 11:42 ` [RFC PATCH net-next 1/3] net: add ndo_update_offloads Hangbin Liu
2026-02-26 11:42 ` [RFC PATCH net-next 2/3] net: use ndo_update_offloads for bonding/bridge/team Hangbin Liu
2026-02-27 7:53 ` Hangbin Liu
2026-02-26 11:42 ` [RFC PATCH net-next 3/3] failover: use .ndo_update_offloads for failover Hangbin Liu
2026-02-26 12:48 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260226114208.27774-1-liuhangbin@gmail.com \
--to=liuhangbin@gmail.com \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=sdf@fomichev.me \
--cc=skhawaja@google.com \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox