From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
"maintainer:OCELOT ETHERNET SWITCH DRIVER"
<UNGLinuxDriver@microchip.com>, Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: dsa: felix: use kmalloc_flex helper
Date: Thu, 26 Feb 2026 15:03:02 +0200 [thread overview]
Message-ID: <20260226130302.jr55botfesrxqddy@skbuf> (raw)
In-Reply-To: <20260225040323.69497-1-rosenp@gmail.com>
On Tue, Feb 24, 2026 at 08:03:23PM -0800, Rosen Penev wrote:
> A little simpler than using a separate size variable.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/net/dsa/ocelot/felix_vsc9959.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c
> index 8387dd208adb..cb132679fd99 100644
> --- a/drivers/net/dsa/ocelot/felix_vsc9959.c
> +++ b/drivers/net/dsa/ocelot/felix_vsc9959.c
> @@ -2254,7 +2254,7 @@ static int vsc9959_psfp_filter_add(struct ocelot *ocelot, int port,
> struct felix_stream_gate *sgi;
> struct ocelot_psfp_list *psfp;
> struct ocelot_policer pol;
> - int ret, i, size;
> + int ret, i;
Please don't break reverse Christmas tree variable ordering.
And put "PATCH v2 net-next" in the git subject prefix.
> u64 rate, burst;
> u32 index;
>
> @@ -2271,8 +2271,7 @@ static int vsc9959_psfp_filter_add(struct ocelot *ocelot, int port,
> flow_action_for_each(i, a, &f->rule->action) {
> switch (a->id) {
> case FLOW_ACTION_GATE:
> - size = struct_size(sgi, entries, a->gate.num_entries);
> - sgi = kzalloc(size, GFP_KERNEL);
> + sgi = kzalloc_flex(*sgi, entries, a->gate.num_entries, GFP_KERNEL);
> if (!sgi) {
> ret = -ENOMEM;
> goto err;
> --
> 2.53.0
>
prev parent reply other threads:[~2026-02-26 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 4:03 [PATCH] net: dsa: felix: use kmalloc_flex helper Rosen Penev
2026-02-25 9:13 ` Jijie Shao
2026-02-26 12:23 ` Simon Horman
2026-02-26 13:03 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260226130302.jr55botfesrxqddy@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox