From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB0203290CB; Thu, 26 Feb 2026 16:22:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772122943; cv=none; b=SE2p6+7PaSqslLsumc2WK0E53ALUuoxAltxQShuqRZsKAUzBkswuiOKqzrlUNIDujRYyAjhpi8bjqUHL15NX6v39KHRLtxNtCEpyq7gk0abcLyAlhCSShPUBQK9XISxcr/MEPLJRFUw4Jhi3uwqo4fTcwsi6JPS1BrWguydL0ww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772122943; c=relaxed/simple; bh=zBSOHROIWzwnJvs9/9cwNsUSUVDRgXIG4XZCDyNzlZs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dSmu7fH90Q1/5vNpTKShG5qD7l/FdWXaDn/PSkIwAxiUxzDQ9M82GCmNDlZHUGzxWwQRotg5pgJ4RiBSbwbGH/OLfzCMbGruQPUATrFvwzC/2UepGIyniwssMVoly1q0bgXZ/yxtyswZ3Tjey4A2bADIWcMgQyu42w0CbcjAd/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JssZjrPw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JssZjrPw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FBF5C116C6; Thu, 26 Feb 2026 16:22:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772122943; bh=zBSOHROIWzwnJvs9/9cwNsUSUVDRgXIG4XZCDyNzlZs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JssZjrPw1BO0Mw8Q9yfwnQsgaD6FpgkNgIWpbVUWXLyeJnokKKg4hk1SAaRN/4Pl2 p5YBVNEqJjiqtkjLnya4b8Ga67KiibEKKFpBd87HHM6a9Nr/QZeAv6psBrGRdFMMiz A9DSSr/iUARrTgSnBid48sZtR6nbfqnBEMtEEnmZIzWpuH9bLY6kY9ErKk7lBImyBm /Lk4+mloyiRijQ2SiVpy8mPc9oycbHcUIEINyu+Tm3ChF79dz7yAux92+Q0KlVrv/G LUTkHVEDI976MFOVD4JvxorvgEXP2iFNe7YZQj9uo/QF6AdIL6XZAAV6xKOXhQSqTF qLmaMxW89/z7g== Date: Thu, 26 Feb 2026 08:22:22 -0800 From: "Darrick J. Wong" To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Dan Williams , Matthew Wilcox , Eric Biggers , "Theodore Y. Ts'o" , Muchun Song , Oscar Salvador , David Hildenbrand , David Howells , Paulo Alcantara , Andreas Dilger , Jan Kara , Jaegeuk Kim , Chao Yu , Trond Myklebust , Anna Schumaker , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Steve French , Ronnie Sahlberg , Shyam Prasad N , Bharath SM , Alexander Aring , Ryusuke Konishi , Viacheslav Dubeyko , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Ilya Dryomov , Alex Markuze , Jan Harkes , coda@cs.cmu.edu, Nicolas Pitre , Tyler Hicks , Amir Goldstein , Christoph Hellwig , John Paul Adrian Glaubitz , Yangtao Li , Mikulas Patocka , David Woodhouse , Richard Weinberger , Dave Kleikamp , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Miklos Szeredi , Anders Larsen , Zhihao Cheng , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Fan Wu , Stephen Smalley , Ondrej Mosnacek , Casey Schaufler , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Sumit Semwal , Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S. Miller" , Jakub Kicinski , Simon Horman , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Martin Schiller , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, nvdimm@lists.linux.dev, fsverity@lists.linux.dev, linux-mm@kvack.org, netfs@lists.linux.dev, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-nilfs@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-xfs@vger.kernel.org, linux-hams@vger.kernel.org, linux-x25@vger.kernel.org Subject: Re: [PATCH 61/61] vfs: update core format strings for u64 i_ino Message-ID: <20260226162222.GH13829@frogsfrogsfrogs> References: <20260226-iino-u64-v1-0-ccceff366db9@kernel.org> <20260226-iino-u64-v1-61-ccceff366db9@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260226-iino-u64-v1-61-ccceff366db9@kernel.org> On Thu, Feb 26, 2026 at 10:56:03AM -0500, Jeff Layton wrote: > Update format strings from %lu/%lx to %llu/%llx and 0UL literal to > 0ULL in pipe, dcache, fserror, and eventpoll, now that i_ino is u64 > instead of unsigned long. > > Signed-off-by: Jeff Layton Acked-by: "Darrick J. Wong" --D > --- > fs/dcache.c | 4 ++-- > fs/eventpoll.c | 2 +- > fs/fserror.c | 2 +- > fs/pipe.c | 2 +- > 4 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fs/dcache.c b/fs/dcache.c > index 24f4f3acaa8cffd6f98124eec38c1a92d6c9fd8e..9e8425ecd88955c72027d21591b1d12c87e7e8aa 100644 > --- a/fs/dcache.c > +++ b/fs/dcache.c > @@ -1637,11 +1637,11 @@ static enum d_walk_ret umount_check(void *_data, struct dentry *dentry) > if (dentry == _data && dentry->d_lockref.count == 1) > return D_WALK_CONTINUE; > > - WARN(1, "BUG: Dentry %p{i=%lx,n=%pd} " > + WARN(1, "BUG: Dentry %p{i=%llx,n=%pd} " > " still in use (%d) [unmount of %s %s]\n", > dentry, > dentry->d_inode ? > - dentry->d_inode->i_ino : 0UL, > + dentry->d_inode->i_ino : 0ULL, > dentry, > dentry->d_lockref.count, > dentry->d_sb->s_type->name, > diff --git a/fs/eventpoll.c b/fs/eventpoll.c > index 5714e900567c499739bb205f43bb6bf73f7ebe54..4ccd4d2e31adf571f939d2e777123e40302e565f 100644 > --- a/fs/eventpoll.c > +++ b/fs/eventpoll.c > @@ -1080,7 +1080,7 @@ static void ep_show_fdinfo(struct seq_file *m, struct file *f) > struct inode *inode = file_inode(epi->ffd.file); > > seq_printf(m, "tfd: %8d events: %8x data: %16llx " > - " pos:%lli ino:%lx sdev:%x\n", > + " pos:%lli ino:%llx sdev:%x\n", > epi->ffd.fd, epi->event.events, > (long long)epi->event.data, > (long long)epi->ffd.file->f_pos, > diff --git a/fs/fserror.c b/fs/fserror.c > index 06ca86adab9b769dfb72ec58b9e51627abee5152..1e4d11fd9562fd158a23b64ca60e9b7e01719cb8 100644 > --- a/fs/fserror.c > +++ b/fs/fserror.c > @@ -176,7 +176,7 @@ void fserror_report(struct super_block *sb, struct inode *inode, > lost: > if (inode) > pr_err_ratelimited( > - "%s: lost file I/O error report for ino %lu type %u pos 0x%llx len 0x%llx error %d", > + "%s: lost file I/O error report for ino %llu type %u pos 0x%llx len 0x%llx error %d", > sb->s_id, inode->i_ino, type, pos, len, error); > else > pr_err_ratelimited( > diff --git a/fs/pipe.c b/fs/pipe.c > index b44a756c0b4165edc2801b2290bf35480245d7a6..9841648c9cf3e8e569cf6ba5c792624fe92396f5 100644 > --- a/fs/pipe.c > +++ b/fs/pipe.c > @@ -873,7 +873,7 @@ static struct vfsmount *pipe_mnt __ro_after_init; > */ > static char *pipefs_dname(struct dentry *dentry, char *buffer, int buflen) > { > - return dynamic_dname(buffer, buflen, "pipe:[%lu]", > + return dynamic_dname(buffer, buflen, "pipe:[%llu]", > d_inode(dentry)->i_ino); > } > > > -- > 2.53.0 > >