From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Patryk <pbiel7@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: Re: 10G-QXGMII phy no autonegotiation on LS1028A
Date: Thu, 26 Feb 2026 18:30:14 +0200 [thread overview]
Message-ID: <20260226163014.byxmgisp3aluv6cf@skbuf> (raw)
In-Reply-To: <CA+DkFDZfJ4kD0=6O6XB5=azeFukiGxou4T0mM30qVktQCB8-1w@mail.gmail.com>
On Thu, Feb 26, 2026 at 05:09:59PM +0100, Patryk wrote:
> As for the phy... I'm aware that this isn't ideal for community
> visibility, but the PHY I'm working with has not been upstreamed yet
> and is currently under a strict NDA. Unfortunately, I cannot disclose
> the specific model at this stage. This is a constraint I'm bound by,
> as I'm working with vendor-supplied sources. I can however patch the
> vendor supplied sources adding modification you suggested so I guess
> the phy will be working as expected.
That's OK. If you can still test on your side with the PHY driver
implementing the inband caps API for both enabled and disabled, and
specify that you did that, I think we can operate on good faith in that
case. I may be able to hack up a PHY-less test rig to double check just
in case, and leave a Tested-by: tag. I can also do a regression test
with in-band autoneg enabled on AQR412C.
> > How do you wish we proceed? Is the above context enough for you to
> > submit patches, or do you need assistance?
>
> Of course I’ll gladly prepare patches. Just to summarize what needs to be done:
> - in lynx_pcs_config_usxgmii the constraint about in-band only
> supported mode should be removed
> - if neg_mode = PHYLINK_PCS_NEG_INBAND_ENABLED then the vendor
> specific registers to enable and restart autoneg (similarly like in
> u-boot) should be configured
> - additionally it should also work without in-band-status defined in
> the device tree
>
> Is this what you're suggesting? I'll proceed with this unless you have
> any objections.
Yep, sounds good. Don't forget to modify lynx_pcs_inband_caps() to make
PHY_INTERFACE_MODE_USXGMII and PHY_INTERFACE_MODE_10G_QXGMII to be
treated like the PHY_INTERFACE_MODE_1000BASEX family (aka report both
LINK_INBAND_DISABLE | LINK_INBAND_ENABLE).
Thanks!
prev parent reply other threads:[~2026-02-26 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 8:32 10G-QXGMII phy no autonegotiation on LS1028A Patryk
2026-02-25 23:26 ` Andrew Lunn
2026-02-26 12:36 ` Vladimir Oltean
2026-02-26 16:09 ` Patryk
2026-02-26 16:30 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260226163014.byxmgisp3aluv6cf@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pbiel7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox