From: Jakub Kicinski <kuba@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: netdev@vger.kernel.org, Aaron Conole <aconole@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
Ilya Maximets <i.maximets@ovn.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
dev@openvswitch.org
Subject: Re: [PATCH -net] net: openvswitch: clean up some kernel-doc warnings
Date: Thu, 26 Feb 2026 16:56:29 -0800 [thread overview]
Message-ID: <20260226165629.377fd10d@kernel.org> (raw)
In-Reply-To: <20260226221054.1041044-1-rdunlap@infradead.org>
On Thu, 26 Feb 2026 14:10:54 -0800 Randy Dunlap wrote:
> + /* private: */
> OVS_DP_ATTR_UNSPEC,
> + /* public: */
Hm, can't quickly grep the relevant guidance but I always thought that
the comment is supposed to pretend to be a label. IOW not be indented:
enum ovs_datapath_attr {
/* private: */
OVS_DP_ATTR_UNSPEC,
/* public: */
OVS_DP_ATTR_NAME, /* name of dp_ifindex netdev */
I find that easier to read, but no strong preference.
next prev parent reply other threads:[~2026-02-27 0:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 22:10 [PATCH -net] net: openvswitch: clean up some kernel-doc warnings Randy Dunlap
2026-02-26 22:57 ` Ilya Maximets
2026-02-27 5:42 ` Randy Dunlap
2026-02-27 10:20 ` Ilya Maximets
2026-02-27 18:12 ` Randy Dunlap
2026-02-27 0:56 ` Jakub Kicinski [this message]
2026-02-27 1:31 ` Randy Dunlap
2026-02-27 10:09 ` Ilya Maximets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260226165629.377fd10d@kernel.org \
--to=kuba@kernel.org \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox