From: Jakub Kicinski <kuba@kernel.org>
To: Adam Young <admiyo@os.amperecomputing.com>
Cc: Sudeep Holla <sudeep.holla@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Robert Moore <robert.moore@intel.com>,
Len Brown <lenb@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeremy Kerr <jk@codeconstruct.com.au>,
Matt Johnston <matt@codeconstruct.com.au>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Huisong Li <lihuisong@huawei.com>
Subject: Re: [net-next v31 1/2] mailbox: pcc: functions for reading and writing PCC extended data
Date: Thu, 26 Feb 2026 18:32:03 -0800 [thread overview]
Message-ID: <20260226183203.4a1d808d@kernel.org> (raw)
In-Reply-To: <20260224231055.393329-2-admiyo@os.amperecomputing.com>
On Tue, 24 Feb 2026 18:10:51 -0500 Adam Young wrote:
> Adds functions that aid in compliance with the PCC protocol by
> checking the command complete flag status.
>
> Adds a function that exposes the size of the shared buffer without
> activating the channel.
>
> Adds a function that allows a client to query the number of bytes
> avaialbel to read in order to preallocate buffers for reading.
All the kdoc you're adding is misformatted, please run
./scripts/kernel-doc -Wall -none to error check
Please look around the kernel to see how well written kdoc looks like
--
pw-bot: cr
next prev parent reply other threads:[~2026-02-27 2:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 23:10 [net-next v31 0/2] MCTP Over PCC Transport Adam Young
2026-02-24 23:10 ` [net-next v31 1/2] mailbox: pcc: functions for reading and writing PCC extended data Adam Young
2026-02-27 2:32 ` Jakub Kicinski [this message]
2026-02-24 23:10 ` [net-next v31 2/2] mctp pcc: Implement MCTP over PCC Transport Adam Young
2026-02-27 2:32 ` Jakub Kicinski
2026-02-27 17:47 ` Adam Young
2026-02-27 17:49 ` Adam Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260226183203.4a1d808d@kernel.org \
--to=kuba@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=admiyo@os.amperecomputing.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jassisinghbrar@gmail.com \
--cc=jk@codeconstruct.com.au \
--cc=lenb@kernel.org \
--cc=lihuisong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=sudeep.holla@arm.com \
--cc=sudeep.holla@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox