From: Alice Mikityanska <alice.kernel@fastmail.im>
To: Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Xin Long <lucien.xin@gmail.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
David Ahern <dsahern@kernel.org>,
Nikolay Aleksandrov <razor@blackwall.org>
Cc: Shuah Khan <shuah@kernel.org>,
Stanislav Fomichev <stfomichev@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Simon Horman <horms@kernel.org>, Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org, Alice Mikityanska <alice@isovalent.com>
Subject: [PATCH net-next v2 01/12] net/sched: act_csum: don't mangle UDP tunnel GSO packets
Date: Thu, 26 Feb 2026 22:15:49 +0200 [thread overview]
Message-ID: <20260226201600.222044-2-alice.kernel@fastmail.im> (raw)
In-Reply-To: <20260226201600.222044-1-alice.kernel@fastmail.im>
From: Alice Mikityanska <alice@isovalent.com>
Similar to commit add641e7dee3 ("sched: act_csum: don't mangle TCP and
UDP GSO packets"), UDP tunnel GSO packets going through act_csum
shouldn't have their checksum calculated at this point, because it will
be done after segmentation. Setting the checksum in act_csum modifies
skb->ip_summed and prevents inner IP csum offload from kicking in,
resulting in a packet with a bad checksum.
Add UDP tunnel GSO packets to the exceptions, and also add UDP GSO
(SKB_GSO_UDP_L4), as the same logic as in the commit mentioned above
applies to UDP GSO too.
Signed-off-by: Alice Mikityanska <alice@isovalent.com>
---
net/sched/act_csum.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/net/sched/act_csum.c b/net/sched/act_csum.c
index 213e1ce9d2da..a5cc76613f32 100644
--- a/net/sched/act_csum.c
+++ b/net/sched/act_csum.c
@@ -259,7 +259,9 @@ static int tcf_csum_ipv4_udp(struct sk_buff *skb, unsigned int ihl,
const struct iphdr *iph;
u16 ul;
- if (skb_is_gso(skb) && skb_shinfo(skb)->gso_type & SKB_GSO_UDP)
+ if (skb_is_gso(skb) && skb_shinfo(skb)->gso_type &
+ (SKB_GSO_UDP | SKB_GSO_UDP_L4 |
+ SKB_GSO_UDP_TUNNEL | SKB_GSO_UDP_TUNNEL_CSUM))
return 1;
/*
@@ -315,7 +317,9 @@ static int tcf_csum_ipv6_udp(struct sk_buff *skb, unsigned int ihl,
const struct ipv6hdr *ip6h;
u16 ul;
- if (skb_is_gso(skb) && skb_shinfo(skb)->gso_type & SKB_GSO_UDP)
+ if (skb_is_gso(skb) && skb_shinfo(skb)->gso_type &
+ (SKB_GSO_UDP | SKB_GSO_UDP_L4 |
+ SKB_GSO_UDP_TUNNEL | SKB_GSO_UDP_TUNNEL_CSUM))
return 1;
/*
--
2.52.0
next prev parent reply other threads:[~2026-02-26 20:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 20:15 [PATCH net-next v2 00/12] BIG TCP for UDP tunnels Alice Mikityanska
2026-02-26 20:15 ` Alice Mikityanska [this message]
2026-02-26 20:15 ` [PATCH net-next v2 02/12] udp: gso: Simplify handling length in GSO_PARTIAL Alice Mikityanska
2026-03-06 20:55 ` Willem de Bruijn
2026-03-06 22:19 ` Alice Mikityanska
2026-03-07 23:23 ` Willem de Bruijn
2026-03-07 23:34 ` Alice Mikityanska
2026-03-07 23:53 ` Willem de Bruijn
2026-02-26 20:15 ` [PATCH net-next v2 03/12] geneve: Fix off-by-one comparing with GRO_LEGACY_MAX_SIZE Alice Mikityanska
2026-02-26 20:20 ` Alice Mikityanska
2026-02-26 20:15 ` [PATCH net-next v2 04/12] net: Use helpers to get/set UDP len tree-wide Alice Mikityanska
2026-02-26 20:19 ` Alice Mikityanska
2026-02-26 20:15 ` [PATCH net-next v2 05/12] net: Enable BIG TCP with partial GSO Alice Mikityanska
2026-02-26 20:15 ` [PATCH net-next v2 06/12] udp: Support gro_ipv4_max_size > 65536 Alice Mikityanska
2026-03-06 21:24 ` Willem de Bruijn
2026-03-06 21:31 ` Willem de Bruijn
2026-02-26 20:15 ` [PATCH net-next v2 07/12] udp: Support BIG TCP GSO packets where they can occur Alice Mikityanska
2026-02-26 20:15 ` [PATCH net-next v2 08/12] udp: Validate UDP length in udp_gro_receive Alice Mikityanska
2026-02-26 20:15 ` [PATCH net-next v2 09/12] udp: Set length in UDP header to 0 for big GSO packets Alice Mikityanska
2026-02-26 20:15 ` [PATCH net-next v2 10/12] vxlan: Enable BIG TCP packets Alice Mikityanska
2026-02-26 20:15 ` [PATCH net-next v2 11/12] geneve: " Alice Mikityanska
2026-02-26 20:16 ` [PATCH net-next v2 12/12] selftests: net: Add a test for BIG TCP in UDP tunnels Alice Mikityanska
2026-02-27 1:30 ` Jakub Kicinski
2026-02-27 9:35 ` Alice Mikityanska
2026-02-27 18:17 ` [syzbot ci] Re: BIG TCP for " syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260226201600.222044-2-alice.kernel@fastmail.im \
--to=alice.kernel@fastmail.im \
--cc=alice@isovalent.com \
--cc=andrew+netdev@lunn.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
--cc=stfomichev@gmail.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox