[PATCH net] selftests/net: packetdrill: remove tests for tcp_rcv_*big

[PATCH net] selftests/net: packetdrill: remove tests for tcp_rcv_*big

[Jakub Kicinski]

Since commit 1d2fbaad7cd8 ("tcp: stronger sk_rcvbuf checks")
has been reverted we need to remove the corresponding tests.

Link: https://lore.kernel.org/20260227003359.2391017-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 .../net/packetdrill/tcp_rcv_big_endseq.pkt    | 44 -------------------
 .../net/packetdrill/tcp_rcv_toobig.pkt        | 33 --------------
 2 files changed, 77 deletions(-)
 delete mode 100644 tools/testing/selftests/net/packetdrill/tcp_rcv_big_endseq.pkt
 delete mode 100644 tools/testing/selftests/net/packetdrill/tcp_rcv_toobig.pkt

diff --git a/tools/testing/selftests/net/packetdrill/tcp_rcv_big_endseq.pkt b/tools/testing/selftests/net/packetdrill/tcp_rcv_big_endseq.pkt
deleted file mode 100644
index 3848b419e68c..000000000000
--- a/tools/testing/selftests/net/packetdrill/tcp_rcv_big_endseq.pkt
+++ /dev/null
@@ -1,44 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-
---mss=1000
-
-`./defaults.sh`
-
-    0 `nstat -n`
-
-// Establish a connection.
-   +0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3
-   +0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0
-   +0 setsockopt(3, SOL_SOCKET, SO_RCVBUF, [10000], 4) = 0
-   +0 bind(3, ..., ...) = 0
-   +0 listen(3, 1) = 0
-
-   +0 < S 0:0(0) win 32792 <mss 1000,nop,wscale 7>
-   +0 > S. 0:0(0) ack 1 <mss 1460,nop,wscale 0>
-  +.1 < . 1:1(0) ack 1 win 257
-
-  +0 accept(3, ..., ...) = 4
-
-  +0 < P. 1:4001(4000) ack 1 win 257
-  +0 > .  1:1(0) ack 4001 win 5000
-
-// packet in sequence : SKB_DROP_REASON_TCP_INVALID_END_SEQUENCE / LINUX_MIB_BEYOND_WINDOW
-  +0 < P. 4001:54001(50000) ack 1 win 257
-  +0 > .  1:1(0) ack 4001 win 5000
-
-// ooo packet. : SKB_DROP_REASON_TCP_INVALID_END_SEQUENCE / LINUX_MIB_BEYOND_WINDOW
-  +1 < P. 5001:55001(50000) ack 1 win 257
-  +0 > .  1:1(0) ack 4001 win 5000
-
-// SKB_DROP_REASON_TCP_INVALID_SEQUENCE / LINUX_MIB_BEYOND_WINDOW
-  +0 < P. 70001:80001(10000) ack 1 win 257
-  +0 > .  1:1(0) ack 4001 win 5000
-
-  +0 read(4, ..., 100000) = 4000
-
-// If queue is empty, accept a packet even if its end_seq is above wup + rcv_wnd
-  +0 < P. 4001:54001(50000) ack 1 win 257
-  +0 > .  1:1(0) ack 54001 win 0
-
-// Check LINUX_MIB_BEYOND_WINDOW has been incremented 3 times.
-+0 `nstat | grep TcpExtBeyondWindow | grep -q " 3 "`
diff --git a/tools/testing/selftests/net/packetdrill/tcp_rcv_toobig.pkt b/tools/testing/selftests/net/packetdrill/tcp_rcv_toobig.pkt
deleted file mode 100644
index f575c0ff89da..000000000000
--- a/tools/testing/selftests/net/packetdrill/tcp_rcv_toobig.pkt
+++ /dev/null
@@ -1,33 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-
---mss=1000
-
-`./defaults.sh`
-
-    0 `nstat -n`
-
-// Establish a connection.
-   +0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3
-   +0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0
-   +0 setsockopt(3, SOL_SOCKET, SO_RCVBUF, [20000], 4) = 0
-   +0 bind(3, ..., ...) = 0
-   +0 listen(3, 1) = 0
-
-   +0 < S 0:0(0) win 32792 <mss 1000,nop,wscale 7>
-   +0 > S. 0:0(0) ack 1 win 18980 <mss 1460,nop,wscale 0>
-  +.1 < . 1:1(0) ack 1 win 257
-
-   +0 accept(3, ..., ...) = 4
-
-   +0 < P. 1:20001(20000) ack 1 win 257
- +.04 > .  1:1(0) ack 20001 win 18000
-
-   +0 setsockopt(4, SOL_SOCKET, SO_RCVBUF, [12000], 4) = 0
-   +0 < P. 20001:80001(60000) ack 1 win 257
-   +0 > .  1:1(0) ack 20001 win 18000
-
-   +0 read(4, ..., 20000) = 20000
-// A too big packet is accepted if the receive queue is empty
-   +0 < P. 20001:80001(60000) ack 1 win 257
-   +0 > .  1:1(0) ack 80001 win 0
-
-- 
2.53.0

Re: [PATCH net] selftests/net: packetdrill: remove tests for tcp_rcv_*big

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 26 Feb 2026 19:34:46 -0800 you wrote:
> Since commit 1d2fbaad7cd8 ("tcp: stronger sk_rcvbuf checks")
> has been reverted we need to remove the corresponding tests.
> 
> Link: https://lore.kernel.org/20260227003359.2391017-1-kuba@kernel.org
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  .../net/packetdrill/tcp_rcv_big_endseq.pkt    | 44 -------------------
>  .../net/packetdrill/tcp_rcv_toobig.pkt        | 33 --------------
>  2 files changed, 77 deletions(-)
>  delete mode 100644 tools/testing/selftests/net/packetdrill/tcp_rcv_big_endseq.pkt
>  delete mode 100644 tools/testing/selftests/net/packetdrill/tcp_rcv_toobig.pkt

Here is the summary with links:
  - [net] selftests/net: packetdrill: remove tests for tcp_rcv_*big
    https://git.kernel.org/netdev/net/c/1cc93c48b5d7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH net] selftests/net: packetdrill: remove tests for tcp_rcv_*big

[Simon Baatz]

Hi Jakub,

On Thu, Feb 26, 2026 at 07:34:46PM -0800, Jakub Kicinski wrote:
> Since commit 1d2fbaad7cd8 ("tcp: stronger sk_rcvbuf checks")
> has been reverted we need to remove the corresponding tests.

tcp_rcv_big_endseq.pkt actually belongs to a different commit and
needs a small tweak to run again. I have posted a patch at
https://lore.kernel.org/netdev/20260301-tcp_rcv_big_endseq-v1-1-86ab7415ab58@gmail.com/

- Simon

-- 
Simon Baatz <gmbnomis@gmail.com>