From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 246F21F92E; Fri, 27 Feb 2026 09:46:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772185563; cv=none; b=P/WyO3/hUIXsJSykDyeANbozHEuA6nzrSP7krPovtuyDm4qA9hONQwgWzELaVMnXs2ridq76NKVv0/gUCxNJYtJ8n1kOfjj4iP02+lPA/VXneoSI53SXChgV2Tb+hPxR2p9OrC7bXpfROOkALwX3w31XTfB351YtUN4bhvMYRGA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772185563; c=relaxed/simple; bh=VYFg5k7FKX+uIcQK8lWyAtUT/QcKiHuyfaKksYCk2iU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XlYQ0nL1i6k6XC6nhPbi9bJBwyS7gU73Tlro+1r2Zyz351U2wOe61SqNZSvPXaFdAUa0QYcDMw6Snw2RcOLkTKRDXkEpPM2cxSk0Y45f8Roovo1U0Aj70IpoaKMUo4QHOT4r5QJPKmMmwIcaPpHOkP2omya4Fj7G4HFTd0WzA0M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=YPLwCRBu; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=flkODPDn; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="YPLwCRBu"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="flkODPDn" Date: Fri, 27 Feb 2026 10:45:58 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1772185560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WADBw/49RgqeVitdv+2eYLg7uk6Rv8a9V1F/vtC1LSE=; b=YPLwCRBuVscCHETXF8Fq24RERTaNwAELr6KN71SwyUy5aULW0SFmZREtwjnOn3HX2j5g5/ eqRhvivi2cz42k3YBJbkmTslvVQk5i9B2aiPapOHqAp5LLTE02TlFRWKhKyCTEKwVfjznu qc4I9vlpZ7G4LLAjUGRfLi/l6C+zGxR+w8bRAKZ0kzFMtGYkPtAMYMxRgfkF2MQUBWjPre hFZPCGGTendy03km4ixm1TioPPAaMHU72U1DQzu5miJXvfAVW1RfTWmTeC2eu9wf9QFhZ3 MY8xTsDjSMCtWWkGpMtOCCLjnPuFJ9oJKMDzsMoy2L+AFw/ixIA9ahF28YMDXg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1772185560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WADBw/49RgqeVitdv+2eYLg7uk6Rv8a9V1F/vtC1LSE=; b=flkODPDnw98wP4j8ocKt4w1Bhv+PAmdeHurV2WTwlhsKIBjUZtqZ7ZMWcHU3T3E35BiL+7 tIB8hz7mzhsrIzCw== From: Sebastian Andrzej Siewior To: Jiayuan Chen Cc: netdev@vger.kernel.org, jiayuna.chen@linux.dev, jiayuna.chen@shopee.com, Jiayuan Chen , syzbot+80e046b8da2820b6ba73@syzkaller.appspotmail.com, Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Andrii Nakryiko , Eduard Zingerman , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Clark Williams , Steven Rostedt , Jussi Maki , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rt-devel@lists.linux.dev Subject: Re: [PATCH net v2 1/2] bonding: fix null-ptr-deref in bond_rr_gen_slave_id() Message-ID: <20260227094558._Fna2iSe@linutronix.de> References: <20260227092254.272603-1-jiayuan.chen@linux.dev> <20260227092254.272603-2-jiayuan.chen@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260227092254.272603-2-jiayuan.chen@linux.dev> On 2026-02-27 17:22:49 [+0800], Jiayuan Chen wrote: > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -6458,6 +6458,12 @@ int bond_create(struct net *net, const char *name) > dev_net_set(bond_dev, net); > bond_dev->rtnl_link_ops = &bond_link_ops; > > + res = bond_create_init(bond); Wouldn't it be better to put into bond_init()? I haven't look into it but when can the bond_mode be changed? Sebastian