public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicolai Buchwitz <nb@tipi-net.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, andrew+netdev@lunn.ch, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk,
	claudiu.beznea@tuxon.dev, nicolas.ferre@microchip.com,
	linux-kernel@vger.kernel.org, theo.lebrun@bootlin.com,
	phil@raspberrypi.com, Nicolai Buchwitz <nb@tipi-net.de>
Subject: [PATCH net-next v5 4/5] net: cadence: macb: enable EEE for Raspberry Pi RP1
Date: Fri, 27 Feb 2026 16:06:09 +0100	[thread overview]
Message-ID: <20260227150610.242215-5-nb@tipi-net.de> (raw)
In-Reply-To: <20260227150610.242215-1-nb@tipi-net.de>

Set MACB_CAPS_EEE for the Raspberry Pi 5 RP1 southbridge
(Cadence GEM_GXL rev 0x00070109 paired with BCM54213PE PHY).

EEE has been verified on RP1 hardware: the LPI counter registers
at 0x270-0x27c return valid data, the TXLPIEN bit in NCR (bit 19)
controls LPI transmission correctly, and ethtool --show-eee reports
the negotiated state after link-up.

Other GEM variants that share the same LPI register layout (SAMA5D2,
SAME70, PIC32CZ) can be enabled by adding MACB_CAPS_EEE to their
respective config entries once tested.

Reviewed-by: Théo Lebrun <theo.lebrun@bootlin.com>
Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
---
 drivers/net/ethernet/cadence/macb_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 3e724417d444..0196a13c0688 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -5529,7 +5529,8 @@ static const struct macb_config eyeq5_config = {
 static const struct macb_config raspberrypi_rp1_config = {
 	.caps = MACB_CAPS_GIGABIT_MODE_AVAILABLE | MACB_CAPS_CLK_HW_CHG |
 		MACB_CAPS_JUMBO |
-		MACB_CAPS_GEM_HAS_PTP,
+		MACB_CAPS_GEM_HAS_PTP |
+		MACB_CAPS_EEE,
 	.dma_burst_length = 16,
 	.clk_init = macb_clk_init,
 	.init = macb_init,
-- 
2.51.0


  parent reply	other threads:[~2026-02-27 15:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 15:06 [PATCH net-next v5 0/5] net: cadence: macb: add IEEE 802.3az EEE support Nicolai Buchwitz
2026-02-27 15:06 ` [PATCH net-next v5 1/5] net: cadence: macb: add EEE LPI statistics counters Nicolai Buchwitz
2026-02-28 13:33   ` Claudiu Beznea
2026-02-27 15:06 ` [PATCH net-next v5 2/5] net: cadence: macb: implement EEE TX LPI support Nicolai Buchwitz
2026-02-28 13:34   ` Claudiu Beznea
2026-03-03  2:15   ` Jakub Kicinski
2026-03-03  8:14     ` Théo Lebrun
2026-03-03 16:53       ` Jakub Kicinski
2026-02-27 15:06 ` [PATCH net-next v5 3/5] net: cadence: macb: add ethtool EEE support Nicolai Buchwitz
2026-02-28 13:32   ` Claudiu Beznea
2026-02-27 15:06 ` Nicolai Buchwitz [this message]
2026-02-28 13:31   ` [PATCH net-next v5 4/5] net: cadence: macb: enable EEE for Raspberry Pi RP1 Claudiu Beznea
2026-02-27 15:06 ` [PATCH net-next v5 5/5] net: cadence: macb: enable EEE for Mobileye EyeQ5 Nicolai Buchwitz
2026-02-28 13:31   ` Claudiu Beznea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260227150610.242215-5-nb@tipi-net.de \
    --to=nb@tipi-net.de \
    --cc=andrew+netdev@lunn.ch \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=pabeni@redhat.com \
    --cc=phil@raspberrypi.com \
    --cc=theo.lebrun@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox