From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA45C271A6D; Sat, 28 Feb 2026 00:55:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772240158; cv=none; b=oVL4t+5hqe2clWv3Uxk//IdnMn2vVZOHZNIM/AAVnQx2i1ZqEotCxIA3Dh5ywfKp2tlqSRHJXSBZlxdTOwBDL4vPb09EBGds8l4B0lvqmu1AswkPUhRs0chy/LX/jGUCkCl+XQI5T+dI7OXWsXjZ94ZJyE39UeIrdgJePbFvOIU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772240158; c=relaxed/simple; bh=vrU43BCMFUhI571ZBbWK67TPeRBthBSfjXT1gOjxGvQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WvwshUacSjr3ipMb26cENucSVo4T95NXUK53IaqhgirLdcOifihA1FcmHz/qQu0UeKFZhTuKTOn9MAqChnlq4Z7qSxU+00wM3g6YWfZLNRWzP7vPcp1USDo7coegqvuFOW+R73RyBG12HdgNnRg+DjcBavqzKAh9zt3zNOcnFo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dRJG/cV8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dRJG/cV8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE281C116C6; Sat, 28 Feb 2026 00:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772240158; bh=vrU43BCMFUhI571ZBbWK67TPeRBthBSfjXT1gOjxGvQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dRJG/cV8UO4EPLOKG0SME4XWTL4z5+/lxOI0LO0x5zNDpR+qZweaw3EUQYWAzB9FT 37zQcfCwjx1gG5dRwZp20pzpF4TNkFE5UcmOT4hRk05N1ImyGFMBPXQIcdcuZCcmas dC8O3aVwWe/GhZIG0cUq8VJgxRXIniKxAfZXa7g/2NO9Y4BXlWSg86KbHD5w2PZtr7 EE7dPsHb0FyJSR/rEvqBiohBTTyWqg4hJikV+Rnp9QyjIAr1g6GZLFvHHnwuDB8ewn C4Yr7XlOLRxL1OmTNEj/wkzNlWm+/HxDV2UK/fMes811tdjUuzNMlvHLbDjQUiy6ze k367Oe98bd7sg== Date: Fri, 27 Feb 2026 16:55:56 -0800 From: Jakub Kicinski To: "Russell King (Oracle)" Cc: Andrew Lunn , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Mohd Ayaan Anwar , Neil Armstrong , netdev@vger.kernel.org, Paolo Abeni , Vinod Koul Subject: Re: [PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation Message-ID: <20260227165556.5cf9e844@kernel.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 28 Feb 2026 00:11:29 +0000 Russell King (Oracle) wrote: > The AI review for patch 7 says: > > This commit fixes a bug but lacks a Fixes: tag. The commit modifies > behavior introduced in 360000820ae2 ("phy: qcom-sgmii-eth: add > .set_mode() and .validate() methods") by making phy_power_on() call > qcom_dwmac_sgmii_phy_calibrate() to restore the previous setup, and by > making qcom_dwmac_sgmii_phy_set_mode() check if the PHY is powered on > before attempting calibration. > > Should this commit include: > > Fixes: 360000820ae2 ("phy: qcom-sgmii-eth: add .set_mode() and .validate() methods") > > which is _wrong_, this isn't a bug fix. Yes, that's what I thought but then I saw the other thread.. > So, in light of AI review being incorrect, my comment about re-sending > due to the AI review is no longer relevant, and no changes are required. Okay. pw-bot: new > The only thing that's necessary is to have Vinod's ack added to patches > 4, 5, 6 and 7, as he gave them against the very first posting of these > on Wednesday. This is despite waiting the required 24h before sending > the first resend.