From: Jakub Kicinski <kuba@kernel.org>
To: Wei Wang <weibunny@fb.com>
Cc: Bobby Eshleman <bobbyeshleman@gmail.com>,
netdev@vger.kernel.org, Daniel Zahka <daniel.zahka@gmail.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
David Wei <dw@davidwei.uk>, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH net-next 3/9] selftests/net: Add env for container based tests
Date: Fri, 27 Feb 2026 18:30:45 -0800 [thread overview]
Message-ID: <20260227183045.234a841b@kernel.org> (raw)
In-Reply-To: <aZ3pl177Q6+uJCCN@devvm11784.nha0.facebook.com>
On Tue, 24 Feb 2026 10:10:31 -0800 Bobby Eshleman wrote:
> > +Local IP prefix/subnet which can be used to allocate extra IP addresses (for
> > +network name spaces behind macvlan, veth, netkit devices). DUT must be
> > +reachable using these addresses from the endpoint.
> > +
> > + +-------------+ +----------------------------+
> > + | INIT NS | | TEST NS |
> > + | +---------+ | | +------------------------+ |
> > + | | NETIF | | bpf | | Netkit | |
> > + | | |-|--------|>| nk_guest | |
> > + | +---------+ | | | {LOCAL_PREFIX_V6}::2:2 | |
> > + | +---------+ | | +------------------------+ |
> > + | | Netkit | | +----------------------------+
> > + | | nk_host | |
> > + | +---------+ |
> > + +-------------+
> > +
>
> One thing I noticed when I tested this was the flow broke down when
> NETIF's address happened to match LOCAL_PREFIX_V6. I didn't fully reason
> through why this was the case, but maybe it's worth mentioning in the
> docs here?
+1 I think it may be useful to add to the diagram some example using
the documentation IPv6 prefix, to explain what the addresses and routes
are in each of the boxes (and please include the remote).
Also
local_prefix = local_prefix.rstrip("/64").rstrip("::").rstrip(":")
please use Python's built in ipaddress. The standard parser will be far
more flexible for user input
next prev parent reply other threads:[~2026-02-28 2:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 0:24 [PATCH net-next 0/9] psp: Add support for dev-assoc/disassoc Wei Wang
2026-02-24 0:24 ` [PATCH net-next 2/9] selftests/net: Export Netlink class via lib.py Wei Wang
2026-02-24 0:24 ` [PATCH net-next 3/9] selftests/net: Add env for container based tests Wei Wang
2026-02-24 18:10 ` Bobby Eshleman
2026-02-28 2:30 ` Jakub Kicinski [this message]
2026-03-01 4:15 ` David Wei
2026-03-01 4:17 ` David Wei
2026-03-01 4:18 ` David Wei
2026-02-24 0:24 ` [PATCH net-next 4/9] selftests/net: Add netkit container ping test Wei Wang
2026-02-24 0:24 ` [PATCH net-next 5/9] psp: add unprivileged version of psp_device_get_locked Wei Wang
2026-02-24 0:24 ` [PATCH net-next 6/9] psp: Add new netlink cmd for dev-assoc and dev-disassoc Wei Wang
2026-02-24 0:24 ` [PATCH net-next 7/9] psp: add a new netdev event for dev unregister Wei Wang
2026-02-24 0:24 ` [PATCH net-next 8/9] selftests/net: Add bpf skb forwarding program Wei Wang
2026-02-24 18:56 ` Bobby Eshleman
2026-02-24 0:24 ` [PATCH net-next 9/9] selftest/net: psp: Add test for dev-assoc/disassoc Wei Wang
2026-02-28 2:33 ` Jakub Kicinski
[not found] ` <20260224002410.1553838-2-weibunny@fb.com>
2026-02-28 2:34 ` [PATCH net-next 1/9] selftests/net: Add bpf skb forwarding program Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260227183045.234a841b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bobbyeshleman@gmail.com \
--cc=daniel.zahka@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=weibunny@fb.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox