From: Eric Dumazet <edumazet@google.com>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Eric Dumazet <edumazet@google.com>
Subject: [PATCH net-next 6/7] net-sysfs: remove rcu field from 'struct rps_dev_flow_table'
Date: Sat, 28 Feb 2026 04:25:02 +0000 [thread overview]
Message-ID: <20260228042503.3726451-7-edumazet@google.com> (raw)
In-Reply-To: <20260228042503.3726451-1-edumazet@google.com>
Remove rps_dev_flow_table_release() in favor of kvfree_rcu_mightsleep().
In the following pach, we will remove "u8 @log" field
and 'struct rps_dev_flow_table' size will be a power-of-two.
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
include/net/rps.h | 1 -
net/core/net-sysfs.c | 11 ++---------
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/include/net/rps.h b/include/net/rps.h
index 0d9ee2a055e9423f23c677fb3b28b5cfe05eb49f..98f96d6c606e63f5ac31a9cf98ce8a0fb6486ba9 100644
--- a/include/net/rps.h
+++ b/include/net/rps.h
@@ -44,7 +44,6 @@ struct rps_dev_flow {
*/
struct rps_dev_flow_table {
u8 log;
- struct rcu_head rcu;
struct rps_dev_flow flows[];
};
#define RPS_DEV_FLOW_TABLE_SIZE(_num) (sizeof(struct rps_dev_flow_table) + \
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 52fcf7fa58a808e79c1a17c8719830bcfb7c1674..fd6f81930bc6437957f32206c84db87ee242fede 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -1072,13 +1072,6 @@ static ssize_t show_rps_dev_flow_table_cnt(struct netdev_rx_queue *queue,
return sysfs_emit(buf, "%lu\n", val);
}
-static void rps_dev_flow_table_release(struct rcu_head *rcu)
-{
- struct rps_dev_flow_table *table = container_of(rcu,
- struct rps_dev_flow_table, rcu);
- vfree(table);
-}
-
static ssize_t store_rps_dev_flow_table_cnt(struct netdev_rx_queue *queue,
const char *buf, size_t len)
{
@@ -1131,7 +1124,7 @@ static ssize_t store_rps_dev_flow_table_cnt(struct netdev_rx_queue *queue,
RCU_INITIALIZER(table)));
if (old_table)
- call_rcu(&old_table->rcu, rps_dev_flow_table_release);
+ kvfree_rcu_mightsleep(old_table);
return len;
}
@@ -1168,7 +1161,7 @@ static void rx_queue_release(struct kobject *kobj)
old_table = unrcu_pointer(xchg(&queue->rps_flow_table, NULL));
if (old_table)
- call_rcu(&old_table->rcu, rps_dev_flow_table_release);
+ kvfree_rcu_mightsleep(old_table);
#endif
memset(kobj, 0, sizeof(*kobj));
--
2.53.0.473.g4a7958ca14-goog
next prev parent reply other threads:[~2026-02-28 4:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 4:24 [PATCH net-next 0/7] rfs: use high-order allocations for hash tables Eric Dumazet
2026-02-28 4:24 ` [PATCH net-next 1/7] net: add rps_tag_ptr type and helpers Eric Dumazet
2026-02-28 4:24 ` [PATCH net-next 2/7] net-sysfs: remove rcu field from 'struct rps_sock_flow_table' Eric Dumazet
2026-02-28 4:24 ` [PATCH net-next 3/7] net-sysfs: add rps_sock_flow_table_mask() helper Eric Dumazet
2026-02-28 4:25 ` [PATCH net-next 4/7] net-sysfs: use rps_tag_ptr and remove metadata from rps_sock_flow_table Eric Dumazet
2026-02-28 8:28 ` kernel test robot
2026-02-28 4:25 ` [PATCH net-next 5/7] net-sysfs: get rid of rps_dev_flow_lock Eric Dumazet
2026-02-28 4:25 ` Eric Dumazet [this message]
2026-02-28 4:25 ` [PATCH net-next 7/7] net-sysfs: use rps_tag_ptr and remove metadata from rps_dev_flow_table Eric Dumazet
2026-02-28 10:03 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260228042503.3726451-7-edumazet@google.com \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox