From: Kibaek Yoo <psykibaek@gmail.com>
To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Kibaek Yoo <psykibaek@gmail.com>
Subject: [PATCH v2 2/2] selftests: net: add macvlan multicast test for shared source MAC
Date: Sat, 28 Feb 2026 16:16:13 +0900 [thread overview]
Message-ID: <20260228071613.4360-2-psykibaek@gmail.com> (raw)
In-Reply-To: <20260228071613.4360-1-psykibaek@gmail.com>
Add a selftest that verifies multicast delivery to a macvlan bridge
port when the source MAC of the incoming frame matches the macvlan's
own MAC address.
This scenario occurs with protocols like VRRP where multiple hosts
share the same virtual MAC address. Without the corresponding kernel
change, macvlan bridge mode does not handle this case and the
multicast frame is not delivered.
Signed-off-by: Kibaek Yoo <psykibaek@gmail.com>
---
tools/testing/selftests/net/Makefile | 1 +
.../selftests/net/macvlan_mcast_shared_mac.sh | 93 +++++++++++++++++++
2 files changed, 94 insertions(+)
create mode 100755 tools/testing/selftests/net/macvlan_mcast_shared_mac.sh
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index afdea6d95bde0..c12f6f600ee5e 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -54,6 +54,7 @@ TEST_PROGS := \
l2tp.sh \
link_netns.py \
lwt_dst_cache_ref_loop.sh \
+ macvlan_mcast_shared_mac.sh \
msg_zerocopy.sh \
nat6to4.sh \
ndisc_unsolicited_na_test.sh \
diff --git a/tools/testing/selftests/net/macvlan_mcast_shared_mac.sh b/tools/testing/selftests/net/macvlan_mcast_shared_mac.sh
new file mode 100755
index 0000000000000..ff5b893472474
--- /dev/null
+++ b/tools/testing/selftests/net/macvlan_mcast_shared_mac.sh
@@ -0,0 +1,93 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0
+#
+# Test multicast delivery to macvlan bridge ports when the source MAC
+# matches the macvlan's own MAC address (e.g., VRRP virtual MAC shared
+# across multiple hosts).
+#
+# Topology:
+#
+# NS_SRC NS_BRIDGE
+# veth_src (SHARED_MAC) <-----> veth_dst
+# |
+# +-- macvlan0 (bridge mode, SHARED_MAC)
+#
+# A multicast packet sent from NS_SRC with source MAC equal to
+# macvlan0's MAC must still be delivered to macvlan0.
+
+source lib.sh
+
+SHARED_MAC="00:00:5e:00:01:01"
+MCAST_ADDR="239.0.0.1"
+
+setup() {
+ setup_ns NS_SRC NS_BRIDGE
+
+ ip -net "${NS_BRIDGE}" link add veth_dst type veth \
+ peer name veth_src netns "${NS_SRC}"
+
+ ip -net "${NS_SRC}" link set veth_src address "${SHARED_MAC}"
+ ip -net "${NS_SRC}" link set veth_src up
+ ip -net "${NS_SRC}" addr add 192.168.1.1/24 dev veth_src
+
+ ip -net "${NS_BRIDGE}" link set veth_dst up
+
+ ip -net "${NS_BRIDGE}" link add macvlan0 link veth_dst \
+ type macvlan mode bridge
+ ip -net "${NS_BRIDGE}" link set macvlan0 address "${SHARED_MAC}"
+ ip -net "${NS_BRIDGE}" link set macvlan0 up
+ ip -net "${NS_BRIDGE}" addr add 192.168.1.2/24 dev macvlan0
+
+ # Accept all multicast so the mc_filter passes for any group.
+ ip -net "${NS_BRIDGE}" link set macvlan0 allmulticast on
+}
+
+cleanup() {
+ rm -f "${CAPFILE}" "${CAPOUT}"
+ cleanup_ns "${NS_SRC}" "${NS_BRIDGE}"
+}
+
+test_macvlan_mcast_shared_mac() {
+ CAPFILE=$(mktemp)
+ CAPOUT=$(mktemp)
+
+ echo "Testing multicast delivery to macvlan with shared source MAC"
+
+ # Listen for one ICMP packet on macvlan0.
+ timeout 5s ip netns exec "${NS_BRIDGE}" \
+ tcpdump -i macvlan0 -c 1 -w "${CAPFILE}" icmp &> "${CAPOUT}" &
+ local pid=$!
+ if ! slowwait 1 grep -qs "listening" "${CAPOUT}"; then
+ echo "[FAIL] tcpdump did not start listening"
+ return "${ksft_fail}"
+ fi
+
+ # Send multicast ping from NS_SRC; source MAC equals macvlan0's MAC.
+ ip netns exec "${NS_SRC}" \
+ ping -W 0.1 -c 3 -I veth_src "${MCAST_ADDR}" &> /dev/null
+
+ wait "${pid}"
+
+ local count
+ count=$(tcpdump -r "${CAPFILE}" 2>/dev/null | wc -l)
+ if [[ "${count}" -ge 1 ]]; then
+ echo "[ OK ]"
+ return "${ksft_pass}"
+ else
+ echo "[FAIL] expected at least 1 ICMP packet on macvlan0," \
+ "got ${count}"
+ return "${ksft_fail}"
+ fi
+}
+
+if [ ! -x "$(command -v tcpdump)" ]; then
+ echo "SKIP: Could not run test without tcpdump tool"
+ exit "${ksft_skip}"
+fi
+
+trap cleanup EXIT
+
+setup
+test_macvlan_mcast_shared_mac
+
+exit $?
--
2.50.1 (Apple Git-155)
next prev parent reply other threads:[~2026-02-28 7:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 10:00 [PATCH] net: macvlan: fix multicast delivery to bridge ports with shared source MAC Kibaek Yoo
2026-02-28 3:04 ` Jakub Kicinski
2026-02-28 7:16 ` [PATCH v2 1/2] net: macvlan: support multicast rx for " Kibaek Yoo
2026-02-28 7:16 ` Kibaek Yoo [this message]
2026-03-04 2:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260228071613.4360-2-psykibaek@gmail.com \
--to=psykibaek@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox