From: Sean Chang <seanwascoding@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
Chuck Lever <chuck.lever@oracle.com>,
David Laight <david.laight.linux@gmail.com>,
nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
trond.myklebust@hammerspace.com, anna@kernel.org
Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sean Chang <seanwascoding@gmail.com>
Subject: [PATCH v5 0/2] Fix compiler warnings/errors in SUNRPC and MACB
Date: Sun, 1 Mar 2026 02:08:19 +0800 [thread overview]
Message-ID: <20260228180821.811683-1-seanwascoding@gmail.com> (raw)
This series addresses compiler warnings and a build error identified across
different architectures and configurations.
The first patch refactors the dfprintk macros in the SUNRPC subsystem. This
global fix silences unused variable warnings and, by incorporating
no_printk(), ensures continued compiler type checking. It also includes
a specific fix for a build error in nfsd (nfsfh.c) uncovered by syzbot
in non-debug configurations.
The second patch fixes a format-truncation warning in the MACB ethernet
driver by ensuring the snprintf output fits within the destination buffer.
v5:
- Simplify dfprintk and dfprintk_rcu macros by removing the redundant 'fmt'
argument and calling no_printk(__VA_ARGS__) directly, as suggested by
David Laight.
- Fix a build error in fs/nfsd/nfsfh.c reported by syzbot. The error was
caused by a mismatch between the variable's lifecycle (defined via
RPC_IFDEBUG) and its usage in dprintk.
- Add Link tag to the syzbot build failure report.
- Update series title to reflect the general nature of the fixes.
v4:
- Refactor patch 1 to use no_printk() in sunrpc headers instead of marking
variables as __maybe_unused. This provides a cleaner, global fix and
enables compiler type checking.
v3:
- Expand commit descriptions to include technical details regarding macro
expansion, as requested by Andrew Lunn.
- Test the different platform, such as ARM, ARM64, X86_64.
v2:
- Split the original treewide patch into subsystem-specific commits.
- Added more detailed commit descriptions to satisfy checkpatch.
Sean Chang (2):
sunrpc: simplify dfprintk macros and fix nfsd build error
net: macb: use ethtool_sprintf to fill ethtool stats strings
drivers/net/ethernet/cadence/macb_main.c | 7 ++-----
fs/nfsd/nfsfh.c | 2 ++
include/linux/sunrpc/debug.h | 4 ++--
3 files changed, 6 insertions(+), 7 deletions(-)
--
2.34.1
next reply other threads:[~2026-02-28 18:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 18:08 Sean Chang [this message]
2026-02-28 18:08 ` [PATCH v5 1/2] sunrpc: simplify dfprintk macros and fix nfsd build error Sean Chang
2026-02-28 22:59 ` kernel test robot
2026-03-01 0:10 ` kernel test robot
2026-03-01 0:31 ` kernel test robot
2026-03-02 9:40 ` Geert Uytterhoeven
2026-03-02 13:13 ` Sean Chang
2026-03-02 13:15 ` Geert Uytterhoeven
2026-03-02 13:21 ` Andy Shevchenko
2026-02-28 18:08 ` [PATCH v5 2/2] net: macb: use ethtool_sprintf to fill ethtool stats strings Sean Chang
2026-03-02 13:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260228180821.811683-1-seanwascoding@gmail.com \
--to=seanwascoding@gmail.com \
--cc=andrew@lunn.ch \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=david.laight.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox