From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FB221BC2A for ; Sun, 1 Mar 2026 00:14:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772324101; cv=none; b=Jy9pNzgCEDIR5IVMB5NXXKBzg13cpyBbTzyqOSbUxt+A0Dal1j48Hsua+QuQ/kiEw8i9EBReP6BoieDtBDZXw6mBDtE617eN2Z1LT3CI0ksJ9TomCcigci3ibOu5m6OojGRoMRTNqqtBuUL2D5qDuzCF+7qvOAA4ANxMCQnO3uU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772324101; c=relaxed/simple; bh=OaUtj2W/CaIahiBMFLAhrH1ZSMd7s39qEsfPdT7abx0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Oa2s1tJJculoSUdxK18CI3QDDSnHj7dZpx9uZ8Y0E/nIpCI7sZ2K+f5jHuWAj8HiTk0+/BwjzlotEX5j/tNBn9XcgqIf2jY0Dv6OFXGhUiu2+2S6pPsGVbyXDoUap7DePOUrJGKxs/CeKIn5iiZphCIhfAXzLiipyAnHju2bT/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bQe5O76S; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bQe5O76S" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-439962ecfb5so368408f8f.2 for ; Sat, 28 Feb 2026 16:14:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772324098; x=1772928898; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zYnsoG7qDnrk7Z/gOuxzAyQoovXIM2RIYjUlYbsloBk=; b=bQe5O76SIAWjoC8Vvu67qJNZDvU6+sINjXetrecVLMB4qzouflNtiS3CXc8ruNKBil N9hLSLcTJ83b5mxapfMwHqhEX9UlaNj7FXdhb9vlFk4mnj1ZV5QOuE62/a5jisex08tT c0KTEDmdLWyLnjD/XjbJADAtU1HHkIK6DEKpie5febXSOGEXl966HZSQQT+//pDsl7jk oyDtkySnknTKp5l42Qw50xnKJGz0vFVeGXPoKnwtHD8EpAMZKbzdCHSCvv6iuz0CCwMS XgWE89Ium91o50YLdQln9tYBeh8+Yfk/qE7XARdxE/63d3ETF8NpSFa7NknTpv6Lc2zS pf4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772324098; x=1772928898; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zYnsoG7qDnrk7Z/gOuxzAyQoovXIM2RIYjUlYbsloBk=; b=Y2+F00VETM14GZFJR9Hxtf/Mthi7CICcGHnbuwem2lN4gPjvrFXJ729L/VeaKE3BRQ qSIdY22nG1DaTxD0j/shK1DWY7pm8guLusnu9JLLzz9hUhbOfPclHiuPA9nWcng/9vrn ZZcvyKoz1eb1rRXc+udRF7zYmP80PVVNHdY5qXn2QQyKcxwZ9f6vy14t6GCYVXyQAMRw 3xggg7liX6iAPZM7MOplCPfQ7+1Qat834twvmY+CBOzmYd5r9y8E8ND4/QtzzIG1GmDq b54Rd4Nn5TnMXU3Ujx4O2iK96MWXum/lTnqsQ0LUxV7fOV9GEJ0dPQxRC/r+HUvmwZ/6 Srtg== X-Forwarded-Encrypted: i=1; AJvYcCXL0k7dydn1BXmrkwzf4c+k0+eH1fWB+jTqxm2x4jUNUta0bXpxwDEETk3SXOoAmRLvEOCQbHI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2PKwm7/BTyJIhb3JuaYkGMFdakjMA5x5RbQRLr6JWpfBS9XX9 S7xxxLl6RMU3m1uoBm/BYogXkXtkB2c+qRoVHkLXz0+YDCg58TP7gPgf X-Gm-Gg: ATEYQzz4vxi3wOrSVvzJ5eessy9CRdyIvVEB7R4mRd7jYNmImyyozl4lR4+C3/djjs4 eQPDvXvH+IUO9Yp++ojyvFqillQ9lygEjJ+51ZrnsRjd+3ISElgpGxaGsZin53ztrPrCyRV4o4W OMZLoHt7D2HKjRpqk7vNpU051j44aCTmnmSaR5u+TiQapaMki0zaZZgaRdR9fntJ43tU1MEs1uL z4e/rZkF7Iempq7PPoSmrOUE2z/Ckhh2rnioYwcIBYw+8EQgUovT2yHIPY/bxuDigXiWluVD2PV leF26SlnVTy80/uuibgF+wM6DOB1E2rR7CdlQR/mO+qV5G9+bfrbRFn0gsy4sd1YaVOc59Gd5Wo w8rKhCwhmSWR8UE1LEaGSZqykkED0v3JXpmTSi/+NUmRfdwDvqgP+09bbq2p3hXjmeTbNUQkFtu 5+X2OLQIEnmij8AIi73XU= X-Received: by 2002:a05:600c:474e:b0:483:7d93:9fb7 with SMTP id 5b1f17b1804b1-483c9b99876mr77353565e9.2.1772324097547; Sat, 28 Feb 2026 16:14:57 -0800 (PST) Received: from skbuf ([2a02:2f04:d608:3a00:53bb:2a43:1888:95a0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd75dfaasm278799855e9.12.2026.02.28.16.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Feb 2026 16:14:56 -0800 (PST) Date: Sun, 1 Mar 2026 02:14:53 +0200 From: Vladimir Oltean To: Jakub Kicinski Cc: "Russell King (Oracle)" , Andrew Lunn , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Mohd Ayaan Anwar , Neil Armstrong , netdev@vger.kernel.org, Paolo Abeni , Vinod Koul Subject: Re: [PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation Message-ID: <20260301001453.lpd2rawy7bqxyivp@skbuf> References: <20260227165556.5cf9e844@kernel.org> <20260228083111.5df8550c@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260228083111.5df8550c@kernel.org> On Sat, Feb 28, 2026 at 08:31:11AM -0800, Jakub Kicinski wrote: > On Fri, 27 Feb 2026 16:55:56 -0800 Jakub Kicinski wrote: > > On Sat, 28 Feb 2026 00:11:29 +0000 Russell King (Oracle) wrote: > > > The AI review for patch 7 says: > > > > > > This commit fixes a bug but lacks a Fixes: tag. The commit modifies > > > behavior introduced in 360000820ae2 ("phy: qcom-sgmii-eth: add > > > .set_mode() and .validate() methods") by making phy_power_on() call > > > qcom_dwmac_sgmii_phy_calibrate() to restore the previous setup, and by > > > making qcom_dwmac_sgmii_phy_set_mode() check if the PHY is powered on > > > before attempting calibration. > > > > > > Should this commit include: > > > > > > Fixes: 360000820ae2 ("phy: qcom-sgmii-eth: add .set_mode() and .validate() methods") > > > > > > which is _wrong_, this isn't a bug fix. > > > > Yes, that's what I thought but then I saw the other thread.. > > Trying to apply this now but stmmac parts don't apply on Linus's tree, > and Vinod wants a tag :( What do we do? > > Could you, perhaps, send us a PR with this on top of Linus's tree > (a resolution of the inevitable conflict with net-next would be helpful > too). > > Or do we give up on the tag? Actually, I think it's mainly me who wants a stable tag. I'm working on a series for phy-next which will conflict with this hunk from Russell's patch 1: diff --git a/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c b/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c index 5b1c82459c12..4ea3dce7719f 100644 --- a/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c +++ b/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c @@ -7,6 +7,7 @@ #include #include #include +#include #include // this gets renamed to #include #include If there's no other way to provide a stable tag other than on v7.0-rc1 (like for example a snapshot of current net-next/main), which I didn't know wouldn't be possible, then I think going with the route of fewer/ more trivial merge conflicts makes sense.