From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 738C11E0B86; Sun, 1 Mar 2026 01:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772328920; cv=none; b=KURGJkDU+0LMkSTKjwnOdO2oDeIjG01SI4KB8gT7JlulTiA3W4xQAytBIsXS9xyg9Ic0+nRaqoaxI2aHs9hlbqsTtHj3GE/Gpd/IiQ+412sZZFUxyCIhl7VxItOFfHlddrTjD6OCvOW+hJbKcbVfSI/fIH22NIkwpFXV1Z8ZIPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772328920; c=relaxed/simple; bh=tnwjU9/x5wnrixeJrcov1u/S5SKVjhsE8VXbdXVrCu8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=MUZqhKYYQn7hyjyHAS+BmwqSytBCVHfSWsU96ItJV7Oyj54SmK5p0i4s6p6ELnUSzeaOVQNHi/yfmPX/wQpfDufGUHYdMmITPzlSU6Md0CEhcZBIycqn5HrAY2juyz3hT3ov+K9065OI2BNu7FM8Cwd4pffZ3xFTHD0Cfz9I3oM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tNErFEXA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tNErFEXA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93B44C19424; Sun, 1 Mar 2026 01:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772328920; bh=tnwjU9/x5wnrixeJrcov1u/S5SKVjhsE8VXbdXVrCu8=; h=From:To:Cc:Subject:Date:From; b=tNErFEXAT/9HG7uCO1cVEuuNWvBNjvaUrkjPx0y+6fgJdp4QYc9NkqFSNAyfWLGrC Eniwk39HhsjPIseIKXaOfsrZv/S7wH5g2GEm5p0Daz2UAS4yjqkPIikQMDPU/5D257 R6ktpf0JLAUCJLT1cNr3iMHfjVhXj5HYXK8TDQlCGdM09K/hGt7yMpXtKakOgef8St PxFSRll8/yZqpB1Z2FwcOUCJ6Ct46AcG1WWgD5eMRH/oc3+uu/+es7SpmsCBOttnP/ Trosf5bCIEjxO+0jdvLbXWxKKWO9MWh8aBGxMXPJSr2CnDaKHqjgRE7Q4PVT/IFlkl EToLEL9c9DS/Q== From: Sasha Levin To: stable@vger.kernel.org, eperezma@redhat.com Cc: Jason Wang , "Michael S. Tsirkin" , virtualization@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: FAILED: Patch "vhost: move vdpa group bound check to vhost_vdpa" failed to apply to 6.6-stable tree Date: Sat, 28 Feb 2026 20:35:18 -0500 Message-ID: <20260301013518.1694956-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From cd025c1e876b4e262e71398236a1550486a73ede Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= Date: Mon, 19 Jan 2026 15:32:54 +0100 Subject: [PATCH] vhost: move vdpa group bound check to vhost_vdpa MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove duplication by consolidating these here. This reduces the posibility of a parent driver missing them. While we're at it, fix a bug in vdpa_sim where a valid ASID can be assigned to a group equal to ngroups, causing an out of bound write. Cc: stable@vger.kernel.org Fixes: bda324fd037a ("vdpasim: control virtqueue support") Acked-by: Jason Wang Signed-off-by: Eugenio Pérez Signed-off-by: Michael S. Tsirkin Message-Id: <20260119143306.1818855-2-eperezma@redhat.com> --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 3 --- drivers/vdpa/vdpa_sim/vdpa_sim.c | 6 ------ drivers/vhost/vdpa.c | 2 +- 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index ddaa1366704bb..44062e9d68f00 100644 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c @@ -3640,9 +3640,6 @@ static int mlx5_set_group_asid(struct vdpa_device *vdev, u32 group, struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev); int err = 0; - if (group >= MLX5_VDPA_NUMVQ_GROUPS) - return -EINVAL; - mvdev->mres.group2asid[group] = asid; mutex_lock(&mvdev->mres.lock); diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c index c1c6431950e1b..df9c7ddc5d782 100644 --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c @@ -606,12 +606,6 @@ static int vdpasim_set_group_asid(struct vdpa_device *vdpa, unsigned int group, struct vhost_iotlb *iommu; int i; - if (group > vdpasim->dev_attr.ngroups) - return -EINVAL; - - if (asid >= vdpasim->dev_attr.nas) - return -EINVAL; - iommu = &vdpasim->iommu[asid]; mutex_lock(&vdpasim->mutex); diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 05a481e4c385a..9d25b735b43dd 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c @@ -680,7 +680,7 @@ static long vhost_vdpa_vring_ioctl(struct vhost_vdpa *v, unsigned int cmd, case VHOST_VDPA_SET_GROUP_ASID: if (copy_from_user(&s, argp, sizeof(s))) return -EFAULT; - if (s.num >= vdpa->nas) + if (idx >= vdpa->ngroups || s.num >= vdpa->nas) return -EINVAL; if (!ops->set_group_asid) return -EOPNOTSUPP; -- 2.51.0