From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
David Ahern <dsahern@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH net-next] ipv6: add IPV6_CALL() helper
Date: Sun, 1 Mar 2026 11:36:43 -0800 [thread overview]
Message-ID: <20260301113643.65e4e90c@kernel.org> (raw)
In-Reply-To: <20260301112413.1b6c785e@kernel.org>
On Sun, 1 Mar 2026 11:24:13 -0800 Jakub Kicinski wrote:
> On Sun, 1 Mar 2026 16:25:14 +0000 Eric Dumazet wrote:
> > ipv6_stub use is racy, we should add READ_ONCE() and WRITE_ONCE(),
> > even if this pointer can only change once.
> >
> > Add IPV6_CALL() macro to factorize the READ_ONCE(), and perform
> > direct calls when CONFIG_IPV6=y.
>
> Some crashiness detected here, I think
Took me a minute to grok it but its obvious in hindsight so to possibly
save you time: fib6_update_sernum_stub() vs fib6_update_sernum()
We now call the wrong function due to the funny naming.
next prev parent reply other threads:[~2026-03-01 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 16:25 [PATCH net-next] ipv6: add IPV6_CALL() helper Eric Dumazet
2026-03-01 19:24 ` Jakub Kicinski
2026-03-01 19:36 ` Jakub Kicinski [this message]
2026-03-01 19:37 ` Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2026-03-02 15:42 Eric Dumazet
2026-03-03 19:15 ` Kuniyuki Iwashima
2026-03-04 1:08 ` Jakub Kicinski
2026-03-04 2:13 ` Eric Dumazet
2026-03-04 2:24 ` Jakub Kicinski
2026-03-04 2:32 ` Eric Dumazet
2026-03-04 2:33 ` Eric Dumazet
2026-03-04 2:45 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260301113643.65e4e90c@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox