From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E26D26A0A7; Tue, 3 Mar 2026 01:11:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772500294; cv=none; b=EzK7/W8KwmDW3oaLRWAX8cvoreY8ZIOl9cwlYP0eARZLQkvTz6lWwMmWiamkgBczbWRY1XsZcZVZxKtaFY9s8UVqOKgmLL2sReq6lQea9A1HOGhXdQ6fqANPvqoStwR2wEGVJf2PbryJvoQBilh2an3rwe9DoJH6gBwTKhSl0tA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772500294; c=relaxed/simple; bh=8hjgCw9tBxfdHn7nYg46ux20VTettEl4HQsWGCPdvaA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=H4q/ce8BJurRBvjR8wmAp7Y7XwepRhJZEMv52B3gT88wwW+deOfmbQOdWDnmHkBzRfXqGbSXxpzYUgiFM+wMjytVrcwEciIUyzPUmzDOfJcUSsXB6VxpDY/tu8zfLPbVb6fgwb1a7TooO8a+y+Pbqc/XPX4CcjpB8Z1lzsZ1v/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UOngzt/p; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UOngzt/p" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC9F9C19423; Tue, 3 Mar 2026 01:11:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772500293; bh=8hjgCw9tBxfdHn7nYg46ux20VTettEl4HQsWGCPdvaA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UOngzt/p8pSLllijatbO4/Gy7fc+I2xwykXJabnI1UymCCMkyw9mEKC5jF/Rt9TCM 4NxdoabAtppSRChGJUvzEnKuecUDe/x2zA1JrihX5rgsNWVmVcKfWi1RqyfPCImw08 i8DkNSm8X9nBKDcK+VkG63rz/Dov1wPeo2ZyooQrYnK9J4znXuUDKHVaTf/f0nFiW9 hO9jpM3IGGcQOwFgVi8kDQIpyv5MWs3pON3WqMONfmg29q7r739wfhMDnFqEe0h1aK c7RUdhMLMMIx31lEzYutAjCv1jGhEzG0icaTJbWNGvrgaifVBsllPFABKO+v8u61YI ye9EYbPYagUwg== Date: Mon, 2 Mar 2026 17:11:31 -0800 From: Jakub Kicinski To: Daniel Borkmann Cc: "Ricardo B. =?UTF-8?B?TWFybGnDqHJl?=" , Martin KaFai Lau , John Fastabend , Stanislav Fomichev , Alexei Starovoitov , Andrii Nakryiko , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= , David Ahern , Jay Vosburgh , Andrew Lunn , Hangbin Liu , Fernando Fernandez Mancera , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 1/3] bpf: bpf_out_neigh_v4: Fix nd_tbl NULL dereference when IPv6 is disabled Message-ID: <20260302171131.28373ccb@kernel.org> In-Reply-To: <0b52257d-d557-4f26-9931-34c81ab621bc@iogearbox.net> References: <20260228-net-nd_tbl_fixes-v1-0-2b2a274df9bb@suse.com> <20260228-net-nd_tbl_fixes-v1-1-2b2a274df9bb@suse.com> <0b52257d-d557-4f26-9931-34c81ab621bc@iogearbox.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 2 Mar 2026 06:58:46 +0100 Daniel Borkmann wrote: > > } else if (nh->nh_family == AF_INET6) { > > + if (!ipv6_stub->nd_tbl) { > > + rcu_read_unlock(); > > + goto out_drop; > > + } > > Can we just completely get rid of allowing IPv6 as a module? > So either its built-in or not available at all, and then we > can get rid of the stub completely rather than adding checks > in various places which also brings a small performance benefit > of not having indirect calls in some places. +1 fwiw, if someone complains we can revert it back in feels like a complete waste of everyone's time to maintain it https://lore.kernel.org/all/20260224180544.3c865751@kernel.org/