From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8F8B33F5B7; Mon, 2 Mar 2026 21:24:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772486678; cv=none; b=L/JsgWZFKHk1oQhxVdVLpceE65J5TzfVnMxeInii05eYGHM5lOrKHuGEhuelGQo/zMHkciL/TS4p4UhWpYnljESTPrb5SmYmud9FjfZebdOchD4XG06l/AHJZnSuTRxuD063kAJrTlwWC1z9g34DGZ7Ut443LD6b1ONnQb9J4lo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772486678; c=relaxed/simple; bh=2Cfkijj60alvXH5PPm4F14EP0ye+11LCUdDUZbJ1uKQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HeZIiH3ogaMJRr1I+qhYe3R81InOYRUVCMcLnvBnFiIujdCOSTQfZmq3F/IWvGI+GYqJNiaseRmuH3gEtqphfSkgvsz3unUhtt9TYxrRS3jYi37Q6Mz/GV/kSac9Lg60V7Lqp7CB2x8GXn1Ix6GxPtUpaCgg8Su1Oni+ywSJAaE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uH2ct0S9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uH2ct0S9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4412C19423; Mon, 2 Mar 2026 21:24:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772486678; bh=2Cfkijj60alvXH5PPm4F14EP0ye+11LCUdDUZbJ1uKQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uH2ct0S9vThZrVYPTo1AjSucjyZYdGuzlYMo05oHkUUY5kG3ZAIutgb6FypGcHUAz MkXU8HIrMPUt1d3gNCI9ii9UNBrKW/Ny1OItVX6gDP6IEeR68jtBmq9jBZzHnjfohe ybXawuYnEHk79HsO9CWtuVis0sVbpU8eU8bmo33mC1p43VAwHpk4faGXWFdQ514QrH /qbWA8GPtbOsAQBeD0TFF+YAEFMidWMEPqTLszAH80QsR3QQnyD8MbHZZ1zmj4gaC0 lJTbg/7rANC5j1w1t35t9Z3/ZUw7ZOYPOFmL+txxIkQT9TDQYQvVkE38WQ5O4bNIUP lOJKQUkcREDAA== Date: Mon, 2 Mar 2026 13:24:36 -0800 From: Eric Biggers To: Dmitry Safonov <0x7f454c46@gmail.com> Cc: netdev@vger.kernel.org, "David S . Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Neal Cardwell , Kuniyuki Iwashima , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net] net/tcp-ao: Fix MAC comparison to be constant-time Message-ID: <20260302212436.GB2143@quark> References: <20260302203600.13561-1-ebiggers@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Mar 02, 2026 at 08:59:50PM +0000, Dmitry Safonov wrote: > On Mon, 2 Mar 2026 at 20:36, Eric Biggers wrote: > > > > To prevent timing attacks, MACs need to be compared in constant > > time. Use the appropriate helper function for this. > > > > Fixes: 0a3a809089eb ("net/tcp: Verify inbound TCP-AO signed segments") > > Cc: stable@vger.kernel.org > > Cc: Dmitry Safonov <0x7f454c46@gmail.com> > > Signed-off-by: Eric Biggers > > Thanks, Eric, LGTM. > > Reviewed-by: Dmitry Safonov <0x7f454c46@gmail.com> > > Could you also send a similar patch for TCP-MD5? > tcp_inbound_md5_hash(), tcp_v{4,6}_send_reset() would need the same change. Already done, it was the first one I sent: https://lore.kernel.org/netdev/20260302203409.13388-1-ebiggers@kernel.org/ - Eric