From: Conor Dooley <conor@kernel.org>
To: Charles Perry <charles.perry@microchip.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/4] dt-bindings: net: cdns,macb: forbid phy nodes for Microchip p64h
Date: Tue, 3 Mar 2026 18:11:42 +0000 [thread overview]
Message-ID: <20260303-curse-shudder-9bd286fa6cd0@spud> (raw)
In-Reply-To: <20260303180318.1814791-3-charles.perry@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 1728 bytes --]
On Tue, Mar 03, 2026 at 10:03:16AM -0800, Charles Perry wrote:
> The GEM IPs within Microchip p64h have their MDIO controllers
> unconnected from any physical pin.
>
> When compiling a p64h device tree with a phy on a GEM node with
> CHECK_DTBS=1, this generates an error like:
>
> ```
> linux/arch/riscv/boot/dts/microchip/p64h-hb130x.dtb:
> ethernet@40004180000 (microchip,p64h-gem): ethernet-phy@0: False
> schema does not allow {'reg': [[0]]}
> from schema $id:
> http://devicetree.org/schemas/net/cdns,macb.yaml#
> ```
This should just be part of the patch adding the compatible. Adding it
incorrectly only to fix it up one patch later doesn't make sense.
Additionally, remove this information about the error adding this
produces, all you need here is the justification for it.
pw-bot: changes-requested
>
> Signed-off-by: Charles Perry <charles.perry@microchip.com>
> ---
> Documentation/devicetree/bindings/net/cdns,macb.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index dff350302098..be66cc9a42fd 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -197,6 +197,17 @@ allOf:
> required:
> - phys
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: microchip,p64h-gem
> + then:
> + patternProperties:
> + "^ethernet-phy@[0-9a-f]$": false
> + properties:
> + mdio: false
> +
> unevaluatedProperties: false
>
> examples:
> --
> 2.47.3
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-03-03 18:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 18:03 [PATCH net-next 0/4] Initial support for p64h GEM Charles Perry
2026-03-03 18:03 ` [PATCH net-next 1/4] dt-bindings: net: cdns,macb: add a compatible for Microchip p64h Charles Perry
2026-03-03 18:18 ` Conor Dooley
2026-03-03 18:54 ` Charles Perry
2026-03-03 19:32 ` Conor Dooley
2026-03-03 20:45 ` Charles Perry
2026-03-03 18:03 ` [PATCH net-next 2/4] dt-bindings: net: cdns,macb: forbid phy nodes " Charles Perry
2026-03-03 18:11 ` Conor Dooley [this message]
2026-03-03 18:57 ` Charles Perry
2026-03-03 18:03 ` [PATCH net-next 3/4] net: macb: add safeguards for jumbo frame larger than 10240 Charles Perry
2026-03-05 11:40 ` Simon Horman
2026-03-05 14:24 ` Charles Perry
2026-03-06 13:04 ` Simon Horman
2026-03-06 15:25 ` Charles Perry
2026-03-03 18:03 ` [PATCH net-next 4/4] net: macb: add support for Microchip p64h ethernet endpoint Charles Perry
2026-03-06 13:04 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303-curse-shudder-9bd286fa6cd0@spud \
--to=conor@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=charles.perry@microchip.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox