From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C4DB34C9A3 for ; Tue, 3 Mar 2026 13:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772544153; cv=none; b=GM50tKeW0k21KYn69ftZ/SC/EqyJKHbWyY1/RC1v7n+B4IB8bCYdcqWR+HndcjkkVCOPH+KB+tWwrXLwQteS7aKT8qtuGa5AfBn2pmx7ZRYqjn7Q8Hh4e/MjZG4z7P2d6r11K5pQmVoL0Yxc1g7UFD8lXvv/kC6H7Pv+4P0S1D0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772544153; c=relaxed/simple; bh=AA/rC8J0bWYxDqY4WhfEhh5yf0+vIt1t0AD3KtpELOE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BagKLgA5Ih+fxA20xPWmaYnDy0jYMerFpgMSn38fgUAI78BXqa3zE54YVk4dW/6TBSV32BQEs/8081zXTfVTwy35psCIYyczAT89fRwsBAhMH6TZEs/UOrjWqNmxR2gHYWhcCANQe8MpLerBnkS0MIGnekEKQF/EfNofAj2HnTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mLQvoYFU; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mLQvoYFU" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48378e60742so6642545e9.1 for ; Tue, 03 Mar 2026 05:22:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772544151; x=1773148951; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=jhjoAq3MmovlrlE8lgBAJ1EdXOnr75atWGwQPHXyE58=; b=mLQvoYFUsaxB2oqpFTKAcasCdy0u/VYZvaQemjYO3XrJkRlFgdYLj1lpITml2savsP YeBuE5hcdvt2/VsZbk72aYv7GOgCJzuVS1PrqBS/rK8qngP7LOQ+zABCVtYC+OXnTSFr Ofo272WawhZi+sCmEtl/5QNx3UqHiVnuhUl1D9o2vVi3aTPrKPznwLpjOhIKQmTQ0odx j6YBkDAXHNcmD0+4Q5ZWstme2zjWUzlxto9+35unHn6fGOPHaFvFwOOYR/nxn215WGXT FGUMdM4V+JPItBx+tifRlDfX26Z8HChctwOmjyvR1QHqfoP6jptqyfOTHdipWuivgmZU ajjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772544151; x=1773148951; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jhjoAq3MmovlrlE8lgBAJ1EdXOnr75atWGwQPHXyE58=; b=CfZ/fp46uO8wpdYo/+WZNx7mNAeTVE1+f+e8KOTKGjG9NE8oIkw5gf9abFJkj4PU8D BoqpEf5hR6IyJKh2gGGZMBtABHy0vJVBP3P41ztNDA4C4RYgp4XFZM/6bX8h/d3WBMux ZcbRAGFOfmw1GVJJXMPTc3E/Jn0x/dgUJA8UgwbhtTHTx9bRLHBq2ouYoo2TCO41SL16 FcBSf3B5yrLaI3KSS1zMQQpkxyQDAZvH8b9USvc9prtNAwlfF7WG+DSs3ip36kJ8nYfM xuBBhDdCGlSOf+ra8M2qAja1Si77iiogtt60dY/up9ucIACmGsQyrHhI/wvIuJdwUQVT XOJw== X-Forwarded-Encrypted: i=1; AJvYcCVNz7SDUqNxHc/ULF8bl79TBVkFzZYZ+G93PCd70wfOCm2hmkVznEZ0KnahjM8hQXcW4ZDnCbI=@vger.kernel.org X-Gm-Message-State: AOJu0YxE9cpVsxANBgv2yGDrxgTyBt2iULwcVTqu6ypoOgAXljXZWF8g aAWgNuPBJWVxisHHp6HWVodTQYoXyTbHnJtpeuwnhUPqJBTtAD48EDRM X-Gm-Gg: ATEYQzybdx9ufkVPSxMyB3c4Mcl9hpMivDcmWZuw0QExt8UoMYo7wnTo3rY8nNeDiJA MGSsaZ8+Mtz8qwqcKnCDvQCS8Bt5E6rWrXlAVqzXsH+kGPv4CIgig5ncmaNrbLwYJqJfKQZcVlu ZrPmxfGXIok1c09+9SysoUfFqzd1WosTw/GHSBnA8VLx1sA+tCDHtznLIzg4lWc/j0BeH2RrBO0 SU95w2MGPomkQbkZ45dV3AarJpBZWM1E4O9rFvbd7l4NCFSRkfQkELvkKzsBk0b1TiSbvjBcLcU WUV5KdeiutLCge/fUc+myvBmg+bR5If9+grmSnaclqUsWonFfelXEd8q8sNhaSj5eRIaTOKvQPZ 25KkEAfLWutiUcFF7a9O5LLbp4ydb+TZq3joNQ5CpWqoSQQdsqsp396VnPQAAYzZOx9YGu6ipGV 57NaCVMuDz2IFlRJo= X-Received: by 2002:a05:600c:8b56:b0:477:9fa8:bc99 with SMTP id 5b1f17b1804b1-483c9bba8cfmr153881545e9.4.1772544150700; Tue, 03 Mar 2026 05:22:30 -0800 (PST) Received: from skbuf ([2a02:2f04:d00e:3600:2472:8e4a:cf12:bb30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485135d0232sm15234605e9.28.2026.03.03.05.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 05:22:29 -0800 (PST) Date: Tue, 3 Mar 2026 15:22:26 +0200 From: Vladimir Oltean To: Jens Emil Schulz =?utf-8?Q?=C3=98stergaard?= Cc: UNGLinuxDriver@microchip.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Woojung Huh , Russell King , Steen Hegelund , Daniel Machon , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next 2/8] dt-bindings: net: lan9645x: add LAN9645X switch bindings Message-ID: <20260303132226.6de5boh5pl6hi3hh@skbuf> References: <20260303-dsa_lan9645x_switch_driver_base-v1-0-bff8ca1396f5@microchip.com> <20260303-dsa_lan9645x_switch_driver_base-v1-0-bff8ca1396f5@microchip.com> <20260303-dsa_lan9645x_switch_driver_base-v1-2-bff8ca1396f5@microchip.com> <20260303-dsa_lan9645x_switch_driver_base-v1-2-bff8ca1396f5@microchip.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260303-dsa_lan9645x_switch_driver_base-v1-2-bff8ca1396f5@microchip.com> <20260303-dsa_lan9645x_switch_driver_base-v1-2-bff8ca1396f5@microchip.com> On Tue, Mar 03, 2026 at 01:22:28PM +0100, Jens Emil Schulz Østergaard wrote: > +examples: > + - | > + soc { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet-switch@0 { > + reg = <0>; > + compatible = "microchip,lan96459f-switch", "microchip,lan96455s-switch"; > + pinctrl-0 = <&lan9645x_leds>; > + pinctrl-names = "default"; > + > + ethernet-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + label = "lan0"; Please remove labels from DSA examples. They do not constitute best practice, and it is preferable they don't leak into device trees by promoting them through binding examples. It is currently recommended to name DSA (like other) network interfaces using udev rules set up by user space. Using labels is perhaps only tolerated for cases where the udev implementation is sub-par, like OpenWrt.