From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8BF63BED37 for ; Tue, 3 Mar 2026 15:16:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772551015; cv=none; b=BFQRttmLJZW4wOHj8eS6nP1p051cd1tY1nCacK2o2nmpI3cUD8AA2rkQucywO3ym5gNZhGwV9O+uIRBaI7SimCshcaT3uaBMl094xJ9kLjpFf935qStSmdPL9kqbZJsmbbuVweYAeQe0mOlGptRoJ9gBYEUHcepnIM4OvMzZKZk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772551015; c=relaxed/simple; bh=lwqjyYch6vh3dzuCIh22Ma60E3/UVejNtUUWdK+HCIs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PsOTrdbeDQwhPzAPRBqBHRsz/fFrM+MKcUDRCet55qCqMjUeSkrRn5cltuCDrWx7CLI/1PjRbtJt4OUy2KQxxH/gI8GHJmT+S7ZykbmW85uL7AvEjMx4U2Aia8d2WxFFWDNMrCM3XlCD2nW1zzJnM4hEe7fWlOC0XhwC/3wVw/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=Xsb9KnWg; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="Xsb9KnWg" Received: from macsyma.thunk.org (pool-173-48-119-12.bstnma.fios.verizon.net [173.48.119.12]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 623FGHAJ030958 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 Mar 2026 10:16:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1772550982; bh=r6x2klXXgoU+8nt+Cp4vS5BDkY5WkDUr+eoNgGYMPDk=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=Xsb9KnWgTfv8t/LCQk50HOx9p+0hK8OzKhUfh8R9Rra+UxXdmPB/0Wk1S75qPMIjz +Eexhiu+7A5Pp58C5Fames3F2P+ZQMlc+bYdRzAGBJ6+Re5iTZgb59V5jok60WwtU4 O+cJPr4MFVudRkYten8VLX3WV+CAlQ43+O4U+9RI/iTlQuBYry1e47/Sb8eaNGI3Aw xZfNesk07bxqxS95PoRd+sqE7Qg8gtTuf2CvkeeHkRdcwkQfhBkOlQjKVCOcDvv4+f tErNa2GkHJmZhQVCBHZ6LI/9sOj7JCPzeGVirZ57PAxsVxtu2vFpw6oh+qj6UKjHiq T6ISKUdZ2tYZQ== Received: by macsyma.thunk.org (Postfix, from userid 15806) id 99AD45ADBA78; Tue, 3 Mar 2026 10:16:17 -0500 (EST) Date: Tue, 3 Mar 2026 10:16:17 -0500 From: "Theodore Tso" To: Jeff Layton Cc: "Darrick J. Wong" , Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Dan Williams , Matthew Wilcox , Eric Biggers , Muchun Song , Oscar Salvador , David Hildenbrand , David Howells , Paulo Alcantara , Andreas Dilger , Jan Kara , Jaegeuk Kim , Chao Yu , Trond Myklebust , Anna Schumaker , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Steve French , Ronnie Sahlberg , Shyam Prasad N , Bharath SM , Alexander Aring , Ryusuke Konishi , Viacheslav Dubeyko , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Ilya Dryomov , Alex Markuze , Jan Harkes , coda@cs.cmu.edu, Nicolas Pitre , Tyler Hicks , Amir Goldstein , Christoph Hellwig , John Paul Adrian Glaubitz , Yangtao Li , Mikulas Patocka , David Woodhouse , Richard Weinberger , Dave Kleikamp , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Miklos Szeredi , Anders Larsen , Zhihao Cheng , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Fan Wu , Stephen Smalley , Ondrej Mosnacek , Casey Schaufler , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Sumit Semwal , Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S. Miller" , Jakub Kicinski , Simon Horman , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Martin Schiller , Eric Paris , Joerg Reuter , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Oliver Hartkopp , Marc Kleine-Budde , David Ahern , Neal Cardwell , Steffen Klassert , Herbert Xu , Remi Denis-Courmont , Marcelo Ricardo Leitner , Xin Long , Magnus Karlsson , Maciej Fijalkowski , Stanislav Fomichev , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, nvdimm@lists.linux.dev, fsverity@lists.linux.dev, linux-mm@kvack.org, netfs@lists.linux.dev, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-nilfs@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-xfs@vger.kernel.org, linux-hams@vger.kernel.org, linux-x25@vger.kernel.org, audit@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-can@vger.kernel.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 001/110] vfs: introduce kino_t typedef and PRIino format macro Message-ID: <20260303151617.GD6520@macsyma-wired.lan> References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-1-e5388800dae0@kernel.org> <20260303012556.GA6520@macsyma-wired.lan> <20260303042546.GF13868@frogsfrogsfrogs> <33228005140684201de2ca0c157441d3b6a06413.camel@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33228005140684201de2ca0c157441d3b6a06413.camel@kernel.org> On Tue, Mar 03, 2026 at 05:53:39AM -0500, Jeff Layton wrote: > > Like I said to Ted, this is just temporary scaffolding for the change. > The PRIino macro is removed in the end. Given that, perhaps you can > overlook the bikeshed's color in this instance? I didn't realize that this was going to disappear in the end. That makes me feel much better about the change. I'd suggest changing the commit description where it claims that we're using something that follows the inttypes.h convention and making it clear that this is temporary and only to preserve bisectability. One question though --- are there *really* places that are using signed inode numbers and trying to print them? If people are trying to use negative inodes to signal an error or some such, the it implies that at least for some file systems, an inode number larger than 2**63 might be problematic. If there is core VFS code that uses a negative inode number then this could be a real potential trap. So are there really code which is doing a printf of 'PRIino "d"'? Or was this to allow the use of of 'PRiino "x"'? - Ted