From: Jakub Kicinski <kuba@kernel.org>
To: David Wei <dw@davidwei.uk>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Joe Damato <joe@dama.to>,
Wei Wang <weibunny@meta.com>,
Bobby Eshleman <bobbyeshleman@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Nikolay Aleksandrov <razor@blackwall.org>
Subject: Re: [PATCH net-next v2 3/4] selftests/net: Add env for container based tests
Date: Tue, 3 Mar 2026 15:47:58 -0800 [thread overview]
Message-ID: <20260303154758.0f55213c@kernel.org> (raw)
In-Reply-To: <20260302053315.1919859-4-dw@davidwei.uk>
On Sun, 1 Mar 2026 21:33:14 -0800 David Wei wrote:
> +class NetDrvContEnv(NetDrvEpEnv):
> + """
> + Class for an environment with a netkit pair setup for forwarding traffic
> + between the physical interface and a network namespace.
> + NETIF = "eth0"
> + LOCAL_V6 = "2001:db8::1"
> + REMOTE_V6 = "2001:db8::2"
> + LOCAL_PREFIX_V6 = "fd00:cafe::"
Since you have to respin for the Makefile issue - could you rewrite this
to use 2001:db8 for all addresses? ULA is a funny and odd thing.
LOCAL_V6 = "2001:db8:1::1"
REMOTE_V6 = "2001:db8:1::2"
LOCAL_PREFIX_V6 = "2001:db8:2::0/64"
?
> + try:
> + net = ipaddress.IPv6Network(local_prefix, strict=False)
> + except ValueError:
> + net = ipaddress.IPv6Network(f"{local_prefix}::/64", strict=False)
dunno if the fallback is really necessary, not including the prefix
length is a bit of a bug IMO.
next prev parent reply other threads:[~2026-03-03 23:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 5:33 [PATCH net-next v2 0/4] selftests/net: add netkit container env and test David Wei
2026-03-02 5:33 ` [PATCH net-next v2 1/4] selftests/net: Add bpf skb forwarding program David Wei
2026-03-02 5:33 ` [PATCH net-next v2 2/4] selftests/net: Export Netlink class via lib.py David Wei
2026-03-03 23:46 ` Jakub Kicinski
2026-03-02 5:33 ` [PATCH net-next v2 3/4] selftests/net: Add env for container based tests David Wei
2026-03-03 23:47 ` Jakub Kicinski [this message]
2026-03-02 5:33 ` [PATCH net-next v2 4/4] selftests/net: Add netkit container ping test David Wei
2026-03-03 23:51 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303154758.0f55213c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bobbyeshleman@gmail.com \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=joe@dama.to \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=sdf@fomichev.me \
--cc=weibunny@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox