From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DD39372687 for ; Tue, 3 Mar 2026 23:47:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772581679; cv=none; b=ikr3PeLI2yEg1hWFN14RIpmpEgc33+/dOALbO9u7MMs7bpNLz/YLnaveGqTwaXZusqKTOTCd/zdkAN5+dVWf2iTl8ybwtZN5dCdswRipY6CYwDJxl50HZUj2dOJFtky2LX0gtGFKKRi5dHURDPKe2NFHJvcdJNcVIMV2zgv6DXY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772581679; c=relaxed/simple; bh=9jDm+G7RdCl59yT6RWWg6MI5+TBnRDJ/FeWsZHEWLkM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VlK5Mrsk3Nio84oxp8exAmMMmuVDDii/5vauASrUuZmmwaaDZl24/ECqX3uqs+VzvCbYW224NGtvG3G6kXuGivZ7L5its2mGPOS51mw8PLdnDDWeEoCnPMq+CRsNZN6HaUvAh+lKh5ii0b37zAD1iLsf6NCvfPunC10Bg0qlYR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Zd/08rzL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Zd/08rzL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4829C116C6; Tue, 3 Mar 2026 23:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772581679; bh=9jDm+G7RdCl59yT6RWWg6MI5+TBnRDJ/FeWsZHEWLkM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Zd/08rzLc7M8JVyAGzKY+I8q10tP0ru1pj9BZKRvPi6tPOBuZ/2vWCYVl57irPgUl pOK/vZ2KrDTPSGVI+eA9ZCDPO2eutkLLgYoZc6VQLP3+P09i/1Y+kqxY21hQ+hBj1q QpMkrd/CxxOt9ztQtDmLKBaDMcZXqYMIbV3S7mUMxmbxFD38Kml9h7+JV59WTbfaCc nKcwrVPEq/gRCfE/MISfk1FE3/hOWVksax5q2m+70nRIeDuik5B4BTn2SU0vtP70Ok 0FPexW65XMGrw7Jprf0hjBO+JWujM1OJOP7GZwagolD4H48nWOVlzNl5ufH01b6Nvs tHN5Xi7PriR1g== Date: Tue, 3 Mar 2026 15:47:58 -0800 From: Jakub Kicinski To: David Wei Cc: netdev@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Joe Damato , Wei Wang , Bobby Eshleman , Stanislav Fomichev , Nikolay Aleksandrov Subject: Re: [PATCH net-next v2 3/4] selftests/net: Add env for container based tests Message-ID: <20260303154758.0f55213c@kernel.org> In-Reply-To: <20260302053315.1919859-4-dw@davidwei.uk> References: <20260302053315.1919859-1-dw@davidwei.uk> <20260302053315.1919859-4-dw@davidwei.uk> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 1 Mar 2026 21:33:14 -0800 David Wei wrote: > +class NetDrvContEnv(NetDrvEpEnv): > + """ > + Class for an environment with a netkit pair setup for forwarding traffic > + between the physical interface and a network namespace. > + NETIF = "eth0" > + LOCAL_V6 = "2001:db8::1" > + REMOTE_V6 = "2001:db8::2" > + LOCAL_PREFIX_V6 = "fd00:cafe::" Since you have to respin for the Makefile issue - could you rewrite this to use 2001:db8 for all addresses? ULA is a funny and odd thing. LOCAL_V6 = "2001:db8:1::1" REMOTE_V6 = "2001:db8:1::2" LOCAL_PREFIX_V6 = "2001:db8:2::0/64" ? > + try: > + net = ipaddress.IPv6Network(local_prefix, strict=False) > + except ValueError: > + net = ipaddress.IPv6Network(f"{local_prefix}::/64", strict=False) dunno if the fallback is really necessary, not including the prefix length is a bit of a bug IMO.