From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B9CB372EF4 for ; Tue, 3 Mar 2026 23:51:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772581864; cv=none; b=dixS4ioVtQu3D1+MP0QhfujqO4WuNanfa9u1AA3u3Dti+f6joJp7CgIhsZpdlbfHgGiBOdrNqaKObGEKVbO2WbPPIblTrobkr3D2Fq8VjhQ+um+PPNCr5G6GCY0hVUwBcLFUHKVae276Ol5Rypcybeij+3/Z6kToG7U3X+ndgQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772581864; c=relaxed/simple; bh=zEgTPChxj4u7k9ir9GB4BDX4ci+E3FeicHFxfp/k7KM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RoFNPzWHCnOufoDlT96/j1ke2GFHJyfA8Fjzt7jkX5gl2NnDMmB/gvpy2GXGWeddjh1Th/h9ImMt8h5wMI3FB26UIpRh94a0bjyakGtGjnqlWIZd0K539qp6/uQZDvVIqYpOpos/ITx7LXVQdLyMXxNCQDqjEyjvZ9MhGYZNG2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZdvuSQ3k; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZdvuSQ3k" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDE36C116C6; Tue, 3 Mar 2026 23:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772581864; bh=zEgTPChxj4u7k9ir9GB4BDX4ci+E3FeicHFxfp/k7KM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZdvuSQ3kzvLwvQ227WEF35947iSGYaaJouj5a7InLrEe9mY2IR7U88WCp5rZwRwL9 B5wlHVIYlDTPBaj7Ey6jKE7pAtHnxPP3JoBPonU0iutp7VdPtpS7fHtX9G2GCMhSpM sP60MgRmUOFcGNd/ky8ZLJYMa4lIaRFPoRLxnE4b50FgsAJ9oy6xUP5ZEFEKO0xBMI LU2qO2l2LSdHomVQ+kW4/lqWs6zM05i24wpat1utMgl6ZrW0bGynaM+CPB3sSC5IkV 1AiEkliwshvCV12i1MGpN1RkGDI+hVh6iN7O1e65Dm5Syuu46eNDndZsfYp/ij6HwL TCWz99IKlf/CA== Date: Tue, 3 Mar 2026 15:51:02 -0800 From: Jakub Kicinski To: David Wei Cc: netdev@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Joe Damato , Wei Wang , Bobby Eshleman , Stanislav Fomichev , Nikolay Aleksandrov Subject: Re: [PATCH net-next v2 4/4] selftests/net: Add netkit container ping test Message-ID: <20260303155102.1c5de2c5@kernel.org> In-Reply-To: <20260302053315.1919859-5-dw@davidwei.uk> References: <20260302053315.1919859-1-dw@davidwei.uk> <20260302053315.1919859-5-dw@davidwei.uk> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 1 Mar 2026 21:33:15 -0800 David Wei wrote: > diff --git a/tools/testing/selftests/drivers/net/hw/config b/tools/testing/selftests/drivers/net/hw/config > index 2307aa001be1..b6524040418e 100644 > --- a/tools/testing/selftests/drivers/net/hw/config > +++ b/tools/testing/selftests/drivers/net/hw/config > @@ -1,3 +1,4 @@ > +CONFIG_BPF_SYSCALL=y > CONFIG_FAIL_FUNCTION=y > CONFIG_FAULT_INJECTION=y > CONFIG_FAULT_INJECTION_DEBUG_FS=y > @@ -5,6 +6,8 @@ CONFIG_FUNCTION_ERROR_INJECTION=y > CONFIG_IO_URING=y > CONFIG_IPV6=y > CONFIG_IPV6_GRE=y > +CONFIG_NETKIT=y > +CONFIG_NET_CLS_BPF=y > CONFIG_NET_IPGRE=y > CONFIG_NET_IPGRE_DEMUX=y > CONFIG_UDMABUF=y the sort order we use ignores _ characters: $ ../nipa/tests/patch/check_selftest/validate_config_format.py tools/testing/selftests/drivers/net/hw/config Validation errors in tools/testing/selftests/drivers/net/hw/config: Lines 9-10 invalid order, CONFIG_NET_CLS_BPF=y should be before CONFIG_NETKIT=y Also here and in patch 2 we're getting new pylint --disable=R warnings. Please fix them where possible.