* review scoring
@ 2026-03-04 2:01 Jakub Kicinski
2026-03-05 15:43 ` Dawid Osuchowski
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2026-03-04 2:01 UTC (permalink / raw)
To: netdev; +Cc: Alexei Starovoitov
Hi!
Alexei just sent an announcement to the BPF list describing
a new system of requiring review participation:
https://lore.kernel.org/all/CAADnVQ+TKKptnNB25V3=bcdybh5G6c2DyW2sYtXvyRaVnPN8MA@mail.gmail.com/
I'm very curious to see how this goes, it definitely feels like
a logical step.
On the netdev side I've been using a patch review queue which
takes into account
- the reviewer score of the author
- the reviewer socre of their employer (using the same logic
I use for the periodic "developer statistics" email),
- quality metrics like "is checkpatch clean"
- whether someone already reviewed the patches on the list
(reviews from the same company do not count)
I've been meaning to send an email to let folks know that I'm doing
this. Most large companies are getting a 2 day delay from this scoring
system. To be clear, I'm not intentionally waiting 2 days before
looking at code (at the cost of my sanity). It's just that with our
patch volume if something gets a 2 day delay there's plenty of patches
that will jump earlier in the queue. And so far advancements in AI
failed to make the days any longer..
the queue: https://netdev.bots.linux.dev/suie.html?delegate=netdev
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: review scoring
2026-03-04 2:01 review scoring Jakub Kicinski
@ 2026-03-05 15:43 ` Dawid Osuchowski
0 siblings, 0 replies; 2+ messages in thread
From: Dawid Osuchowski @ 2026-03-05 15:43 UTC (permalink / raw)
To: Jakub Kicinski, netdev; +Cc: Alexei Starovoitov
On 2026-03-04 3:01 AM, Jakub Kicinski wrote:
> Hi!
>
> Alexei just sent an announcement to the BPF list describing
> a new system of requiring review participation:
> https://lore.kernel.org/all/CAADnVQ+TKKptnNB25V3=bcdybh5G6c2DyW2sYtXvyRaVnPN8MA@mail.gmail.com/
> I'm very curious to see how this goes, it definitely feels like
> a logical step.
>
> On the netdev side I've been using a patch review queue which
> takes into account
> - the reviewer score of the author
> - the reviewer socre of their employer (using the same logic
> I use for the periodic "developer statistics" email),
> - quality metrics like "is checkpatch clean"
> - whether someone already reviewed the patches on the list
> (reviews from the same company do not count)
>
> I've been meaning to send an email to let folks know that I'm doing
> this. Most large companies are getting a 2 day delay from this scoring
> system. To be clear, I'm not intentionally waiting 2 days before
> looking at code (at the cost of my sanity). It's just that with our
> patch volume if something gets a 2 day delay there's plenty of patches
...
> that will jump earlier in the queue. And so far advancements in AI
> failed to make the days any longer..
Hey Kuba,
I don't think that's possible, but it hopefully AI could make our
working days shorter by offloading some of our work or making it more
efficient ;) I just hope we will circumvent / prevent AI slop from
taking over.
> the queue: https://netdev.bots.linux.dev/suie.html?delegate=netdev
In all seriousness, thanks for sharing this and maybe this will help get
some execs and other higher-ups across the broad corporate Linux kernel
world to give more time to engineers to perform reviews for other
company / community patches as well.
Best regards,
Dawid
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-05 15:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-04 2:01 review scoring Jakub Kicinski
2026-03-05 15:43 ` Dawid Osuchowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox