* [PATCH] net: xgbe: use device_get_mac_addr
@ 2026-03-04 4:22 Rosen Penev
2026-03-07 0:59 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-03-04 4:22 UTC (permalink / raw)
To: netdev
Cc: Raju Rangoju, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, open list
device_get_mac_addr is basically device_property_read_u8_array with an
is_valid_ether_addr call. Allows just checking for ret.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-platform.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-platform.c b/drivers/net/ethernet/amd/xgbe/xgbe-platform.c
index 47d53e59ccf6..0d1b2e4ca8d3 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-platform.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-platform.c
@@ -252,10 +252,8 @@ static int xgbe_platform_probe(struct platform_device *pdev)
dev_dbg(dev, "sir1_regs = %p\n", pdata->sir1_regs);
/* Retrieve the MAC address */
- ret = device_property_read_u8_array(dev, XGBE_MAC_ADDR_PROPERTY,
- pdata->mac_addr,
- sizeof(pdata->mac_addr));
- if (ret || !is_valid_ether_addr(pdata->mac_addr)) {
+ ret = device_get_mac_address(dev, pdata->mac_addr);
+ if (ret) {
dev_err(dev, "invalid %s property\n", XGBE_MAC_ADDR_PROPERTY);
if (!ret)
ret = -EINVAL;
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net: xgbe: use device_get_mac_addr
2026-03-04 4:22 [PATCH] net: xgbe: use device_get_mac_addr Rosen Penev
@ 2026-03-07 0:59 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2026-03-07 0:59 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, Raju Rangoju, Andrew Lunn, David S. Miller, Eric Dumazet,
Paolo Abeni, open list
On Tue, 3 Mar 2026 20:22:40 -0800 Rosen Penev wrote:
> - ret = device_property_read_u8_array(dev, XGBE_MAC_ADDR_PROPERTY,
> - pdata->mac_addr,
> - sizeof(pdata->mac_addr));
> - if (ret || !is_valid_ether_addr(pdata->mac_addr)) {
> + ret = device_get_mac_address(dev, pdata->mac_addr);
> + if (ret) {
> dev_err(dev, "invalid %s property\n", XGBE_MAC_ADDR_PROPERTY);
Feels a little odd to still use XGBE_MAC_ADDR_PROPERTY in the error
message when now we support any property name for MAC address.
Let's rewrite the error to "invalid MAC address property\n"
and delete XGBE_MAC_ADDR_PROPERTY
--
pw-bot: cr
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-07 0:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-04 4:22 [PATCH] net: xgbe: use device_get_mac_addr Rosen Penev
2026-03-07 0:59 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox