From: Jakub Kicinski <kuba@kernel.org>
To: Bhargava Chenna Marreddy <bhargava.marreddy@broadcom.com>
Cc: edumazet@google.com, andrew+netdev@lunn.ch,
ajit.khaparde@broadcom.com, horms@kernel.org, pabeni@redhat.com,
michael.chan@broadcom.com, linux-kernel@vger.kernel.org,
vsrama-krishna.nemani@broadcom.com, davem@davemloft.net,
netdev@vger.kernel.org, rajashekar.hudumula@broadcom.com,
vikas.gupta@broadcom.com, pavan.chebbi@broadcom.com,
rahul-rg.gupta@broadcom.com
Subject: Re: [net-next,v3,3/8] bng_en: add ethtool link settings, get_link, and nway_reset
Date: Wed, 4 Mar 2026 10:17:35 -0800 [thread overview]
Message-ID: <20260304101735.41b247eb@kernel.org> (raw)
In-Reply-To: <CANXQDtZZTmh1axG3AnM0WH4FgDh0b9Mm5JqdUd+41CqdMg7Zjg@mail.gmail.com>
On Wed, 4 Mar 2026 16:07:09 +0530 Bhargava Chenna Marreddy wrote:
> The code was functionally safe, but I agree the inconsistency in the
> array patterns was not ideal.
Well TBH I think AI is being generous in how it phrases it's feedback.
Assuming an arbitrary value in an enum is and always will be the last
one is asking for bugs.
next prev parent reply other threads:[~2026-03-04 18:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 7:27 [PATCH net-next v3 0/8] bng_en: add link management and statistics support Bhargava Marreddy
2026-02-28 7:27 ` [PATCH net-next v3 1/8] bng_en: add per-PF workqueue, timer, and slow-path task Bhargava Marreddy
2026-02-28 7:27 ` [PATCH net-next v3 2/8] bng_en: query PHY capabilities and report link status Bhargava Marreddy
2026-02-28 7:27 ` [PATCH net-next v3 3/8] bng_en: add ethtool link settings, get_link, and nway_reset Bhargava Marreddy
2026-03-03 3:00 ` [net-next,v3,3/8] " Jakub Kicinski
2026-03-04 10:37 ` Bhargava Chenna Marreddy
2026-03-04 18:17 ` Jakub Kicinski [this message]
2026-03-05 10:51 ` Bhargava Chenna Marreddy
2026-02-28 7:27 ` [PATCH net-next v3 4/8] bng_en: implement ethtool pauseparam operations Bhargava Marreddy
2026-02-28 7:27 ` [PATCH net-next v3 5/8] bng_en: add support for link async events Bhargava Marreddy
2026-02-28 7:27 ` [PATCH net-next v3 6/8] bng_en: add initial support for ethtool stats display Bhargava Marreddy
2026-03-03 3:00 ` [net-next,v3,6/8] " Jakub Kicinski
2026-03-04 8:08 ` Bhargava Chenna Marreddy
2026-03-04 18:22 ` Jakub Kicinski
2026-03-05 10:33 ` Bhargava Chenna Marreddy
2026-02-28 7:27 ` [PATCH net-next v3 7/8] bng_en: periodically fetch and accumulate hardware statistics Bhargava Marreddy
2026-02-28 7:27 ` [PATCH net-next v3 8/8] bng_en: implement ndo_get_stats64 Bhargava Marreddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260304101735.41b247eb@kernel.org \
--to=kuba@kernel.org \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=bhargava.marreddy@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=rahul-rg.gupta@broadcom.com \
--cc=rajashekar.hudumula@broadcom.com \
--cc=vikas.gupta@broadcom.com \
--cc=vsrama-krishna.nemani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox